diff options
| author | Sandrine Bailleux <sandrine.bailleux@arm.com> | 2016-06-02 11:19:59 +0100 |
|---|---|---|
| committer | Sandrine Bailleux <sandrine.bailleux@arm.com> | 2016-06-06 08:52:04 +0100 |
| commit | f607739cba154a0fa23d5e413c21373af8d94b2c (patch) | |
| tree | 77f3c351e1bcebfcc96f55b41cc7adf576a2e666 /Makefile | |
| parent | 754d78b1b331b07456c6ea439e401402a186c626 (diff) | |
Move checkpatch options in a configuration file
At the moment, the top Makefile specifies the options to pass to the
checkpatch script in order to check the coding style. The checkpatch
script also supports reading its options from a configuration file
rather than from the command line.
This patch makes use of this feature and moves the checkpatch options
out of the Makefile. This simplifies the Makefile and makes things
clearer.
This patch also adds some more checkpatch options:
--showfile
--ignore FILE_PATH_CHANGES
--ignore AVOID_EXTERNS
--ignore NEW_TYPEDEFS
--ignore VOLATILE
The rationale behind each of these options has been documented
in the configuration file.
Change-Id: I423e1abe5670c0f57046cbf705f89a8463898676
Diffstat (limited to 'Makefile')
| -rw-r--r-- | Makefile | 8 |
1 files changed, 2 insertions, 6 deletions
@@ -107,11 +107,7 @@ PL011_GENERIC_UART := 0 # Checkpatch script options ################################################################################ -CHECK_IGNORE := --ignore COMPLEX_MACRO \ - --ignore GERRIT_CHANGE_ID \ - --ignore GIT_COMMIT_ID -CHECKPATCH_ARGS := --no-tree --no-signoff ${CHECK_IGNORE} -CHECKCODE_ARGS := --no-patch --no-tree --no-signoff ${CHECK_IGNORE} +CHECKCODE_ARGS := --no-patch # Do not check the coding style on imported library files or documentation files INC_LIB_DIRS_TO_CHECK := $(sort $(filter-out \ include/lib/libfdt \ @@ -571,7 +567,7 @@ checkcodebase: locate-checkpatch checkpatch: locate-checkpatch @echo " CHECKING STYLE" - ${Q}git log -p ${BASE_COMMIT}..HEAD -- ${CHECK_PATHS} | ${CHECKPATCH} ${CHECKPATCH_ARGS} - || true + ${Q}git log -p ${BASE_COMMIT}..HEAD -- ${CHECK_PATHS} | ${CHECKPATCH} - || true certtool: ${CRTTOOL} |