diff options
| author | Konstantin Porotchkin <kostap@marvell.com> | 2018-02-13 14:41:21 +0200 |
|---|---|---|
| committer | Kostya Porotchkin <kostap@marvell.com> | 2018-02-13 18:03:22 +0200 |
| commit | dc4885f5c1920892362315fe072d3644d1cb1fd3 (patch) | |
| tree | 3a39fee0e92dc144eaff2b548779c74e938197ca /drivers | |
| parent | 2f7c080faee4130b31901e3af7ef9ba9368dbe5f (diff) | |
fix: mvebu: i2c: miinor cleanup of the driver code
- Reduce non-critical message level from ERROR to INFO
- Return error in the read or write function fails after
maximum retries.
Change-Id: Iac61246252f1f4981d0f4d5f78dcbe31e910e228
Signed-off-by: Konstantin Porotchkin <kostap@marvell.com>
Reviewed-on: http://vgitil04.il.marvell.com:8080/50514
Tested-by: iSoC Platform CI <ykjenk@marvell.com>
Reviewed-by: Hanna Hawa <hannah@marvell.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/marvell/i2c/a8k_i2c.c | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/drivers/marvell/i2c/a8k_i2c.c b/drivers/marvell/i2c/a8k_i2c.c index 9dec9add..1a45c84d 100644 --- a/drivers/marvell/i2c/a8k_i2c.c +++ b/drivers/marvell/i2c/a8k_i2c.c @@ -244,7 +244,7 @@ static int marvell_i2c_address_set(uint8_t chain, int command) ((status != I2C_STATUS_ADDR_W_ACK) && (command == I2C_CMD_WRITE))) { /* only in debug, since in boot we try to read the SPD of both DRAM, and we don't want error messages in case DIMM doesn't exist. */ - ERROR("%s: ERROR - status %x addr in %s mode.\n", __func__, status, (command == I2C_CMD_WRITE) ? + INFO("%s: ERROR - status %x addr in %s mode.\n", __func__, status, (command == I2C_CMD_WRITE) ? "Write" : "Read"); return -EPERM; } @@ -432,8 +432,10 @@ static int marvell_i2c_unstuck(int ret) do { v = mmio_read_32((uintptr_t)&base->unstuck); } while (v & I2C_UNSTUCK_ONGOING); + if (v & I2C_UNSTUCK_ERROR) { VERBOSE("failed - soft reset i2c\n"); + ret = -EPERM; } else { VERBOSE("ok\n"); i2c_init(base); @@ -537,12 +539,14 @@ int i2c_read(uint8_t chip, uint32_t addr, int alen, uint8_t *buffer, int len) ret = marvell_i2c_stop_bit_set(); } while ((ret == -EAGAIN) && (counter < I2C_MAX_RETRY_CNT)); - if (counter == I2C_MAX_RETRY_CNT) + if (counter == I2C_MAX_RETRY_CNT) { ERROR("I2C transactions failed, got EAGAIN %d times\n", I2C_MAX_RETRY_CNT); + ret = -EPERM; + } mmio_write_32((uintptr_t)&base->control, mmio_read_32((uintptr_t)&base->control) | I2C_CONTROL_ACK); udelay(1); - return 0; + return ret; } /* @@ -598,9 +602,11 @@ int i2c_write(uint8_t chip, uint32_t addr, int alen, uint8_t *buffer, int len) ret = marvell_i2c_stop_bit_set(); } while ((ret == -EAGAIN) && (counter < I2C_MAX_RETRY_CNT)); - if (counter == I2C_MAX_RETRY_CNT) + if (counter == I2C_MAX_RETRY_CNT) { ERROR("I2C transactions failed, got EAGAIN %d times\n", I2C_MAX_RETRY_CNT); + ret = -EPERM; + } udelay(1); - return 0; + return ret; } |