diff options
author | Masahiro Yamada <yamada.masahiro@socionext.com> | 2018-02-02 15:09:36 +0900 |
---|---|---|
committer | Kostya Porotchkin <kostap@marvell.com> | 2018-06-24 12:32:08 +0300 |
commit | 00e9dff083119941de247e69b7c02d6fe05c32f3 (patch) | |
tree | 8d19a088db809ed094cf17d85be8eb956377f41b /plat/common/aarch64/plat_common.c | |
parent | 0c2ed79335f0d66395a168345621ada731e8d5ac (diff) |
types: use int-ll64 for both aarch32 and aarch64
Since commit 031dbb122472 ("AArch32: Add essential Arch helpers"),
it is difficult to use consistent format strings for printf() family
between aarch32 and aarch64.
For example, uint64_t is defined as 'unsigned long long' for aarch32
and as 'unsigned long' for aarch64. Likewise, uintptr_t is defined
as 'unsigned int' for aarch32, and as 'unsigned long' for aarch64.
A problem typically arises when you use printf() in common code.
One solution could be, to cast the arguments to a type long enough
for both architectures. For example, if 'val' is uint64_t type,
like this:
printf("val = %llx\n", (unsigned long long)val);
Or, somebody may suggest to use a macro provided by <inttypes.h>,
like this:
printf("val = %" PRIx64 "\n", val);
But, both would make the code ugly.
The solution adopted in Linux kernel is to use the same typedefs for
all architectures. The fixed integer types in the kernel-space have
been unified into int-ll64, like follows:
typedef signed char int8_t;
typedef unsigned char uint8_t;
typedef signed short int16_t;
typedef unsigned short uint16_t;
typedef signed int int32_t;
typedef unsigned int uint32_t;
typedef signed long long int64_t;
typedef unsigned long long uint64_t;
[ Linux commit: 0c79a8e29b5fcbcbfd611daf9d500cfad8370fcf ]
This gets along with the codebase shared between 32 bit and 64 bit,
with the data model called ILP32, LP64, respectively.
The width for primitive types is defined as follows:
ILP32 LP64
int 32 32
long 32 64
long long 64 64
pointer 32 64
'long long' is 64 bit for both, so it is used for defining uint64_t.
'long' has the same width as pointer, so for uintptr_t.
We still need an ifdef conditional for (s)size_t.
All 64 bit architectures use "unsigned long" size_t, and most 32 bit
architectures use "unsigned int" size_t. H8/300, S/390 are known as
exceptions; they use "unsigned long" size_t despite their architecture
is 32 bit.
One idea for simplification might be to define size_t as 'unsigned long'
across architectures, then forbid the use of "%z" string format.
However, this would cause a distortion between size_t and sizeof()
operator. We have unknowledge about the native type of sizeof(), so
we need a guess of it anyway. I want the following formula to always
return 1:
__builtin_types_compatible_p(size_t, typeof(sizeof(int)))
Fortunately, ARM is probably a majority case. As far as I know, all
32 bit ARM compilers use "unsigned int" size_t.
Change-Id: I20af6905d77bf8fad92808066654a4e6c147c2be
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-on: http://vgitil04.il.marvell.com:8080/57118
Reviewed-by: Omri Itach <omrii@marvell.com>
Tested-by: Kostya Porotchkin <kostap@marvell.com>
Diffstat (limited to 'plat/common/aarch64/plat_common.c')
-rw-r--r-- | plat/common/aarch64/plat_common.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/plat/common/aarch64/plat_common.c b/plat/common/aarch64/plat_common.c index ddd29f29..7a2f38cb 100644 --- a/plat/common/aarch64/plat_common.c +++ b/plat/common/aarch64/plat_common.c @@ -93,7 +93,7 @@ void bl31_early_platform_setup2(u_register_t arg0, u_register_t arg1, */ void plat_sdei_handle_masked_trigger(uint64_t mpidr, unsigned int intr) { - WARN("Spurious SDEI interrupt %u on masked PE %lx\n", intr, mpidr); + WARN("Spurious SDEI interrupt %u on masked PE %llx\n", intr, mpidr); } /* |