diff options
| author | Jacob Pan <jacob.pan.linux@gmail.com> | 2020-09-25 09:32:45 -0700 | 
|---|---|---|
| committer | Joerg Roedel <jroedel@suse.de> | 2020-10-01 14:52:46 +0200 | 
| commit | 23cc3493b5e107b8deb697cf3157a07276b5eff7 (patch) | |
| tree | 190141930a9a5447479ecade78e6406456d70523 | |
| parent | 8d3bb3b8cbf2ffb3ef73720a48b3445518dcdb55 (diff) | |
iommu/uapi: Rename uapi functions
User APIs such as iommu_sva_unbind_gpasid() may also be used by the
kernel. Since we introduced user pointer to the UAPI functions,
in-kernel callers cannot share the same APIs. In-kernel callers are also
trusted, there is no need to validate the data.
We plan to have two flavors of the same API functions, one called
through ioctls, carrying a user pointer and one called directly with
valid IOMMU UAPI structs. To differentiate both, let's rename existing
functions with an iommu_uapi_ prefix.
Suggested-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Link: https://lore.kernel.org/r/1601051567-54787-5-git-send-email-jacob.jun.pan@linux.intel.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
| -rw-r--r-- | drivers/iommu/iommu.c | 18 | ||||
| -rw-r--r-- | include/linux/iommu.h | 31 | 
2 files changed, 25 insertions, 24 deletions
| diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 6c14c88cd525..e412a0abfefa 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -1961,35 +1961,35 @@ out_unlock:  }  EXPORT_SYMBOL_GPL(iommu_attach_device); -int iommu_cache_invalidate(struct iommu_domain *domain, struct device *dev, -			   struct iommu_cache_invalidate_info *inv_info) +int iommu_uapi_cache_invalidate(struct iommu_domain *domain, struct device *dev, +				struct iommu_cache_invalidate_info *inv_info)  {  	if (unlikely(!domain->ops->cache_invalidate))  		return -ENODEV;  	return domain->ops->cache_invalidate(domain, dev, inv_info);  } -EXPORT_SYMBOL_GPL(iommu_cache_invalidate); +EXPORT_SYMBOL_GPL(iommu_uapi_cache_invalidate); -int iommu_sva_bind_gpasid(struct iommu_domain *domain, -			   struct device *dev, struct iommu_gpasid_bind_data *data) +int iommu_uapi_sva_bind_gpasid(struct iommu_domain *domain, +			       struct device *dev, struct iommu_gpasid_bind_data *data)  {  	if (unlikely(!domain->ops->sva_bind_gpasid))  		return -ENODEV;  	return domain->ops->sva_bind_gpasid(domain, dev, data);  } -EXPORT_SYMBOL_GPL(iommu_sva_bind_gpasid); +EXPORT_SYMBOL_GPL(iommu_uapi_sva_bind_gpasid); -int iommu_sva_unbind_gpasid(struct iommu_domain *domain, struct device *dev, -			     ioasid_t pasid) +int iommu_uapi_sva_unbind_gpasid(struct iommu_domain *domain, struct device *dev, +				 ioasid_t pasid)  {  	if (unlikely(!domain->ops->sva_unbind_gpasid))  		return -ENODEV;  	return domain->ops->sva_unbind_gpasid(dev, pasid);  } -EXPORT_SYMBOL_GPL(iommu_sva_unbind_gpasid); +EXPORT_SYMBOL_GPL(iommu_uapi_sva_unbind_gpasid);  static void __iommu_detach_device(struct iommu_domain *domain,  				  struct device *dev) diff --git a/include/linux/iommu.h b/include/linux/iommu.h index 2ad26d8b4ab9..d18de2afa6fb 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -424,13 +424,13 @@ extern int iommu_attach_device(struct iommu_domain *domain,  			       struct device *dev);  extern void iommu_detach_device(struct iommu_domain *domain,  				struct device *dev); -extern int iommu_cache_invalidate(struct iommu_domain *domain, -				  struct device *dev, -				  struct iommu_cache_invalidate_info *inv_info); -extern int iommu_sva_bind_gpasid(struct iommu_domain *domain, -		struct device *dev, struct iommu_gpasid_bind_data *data); -extern int iommu_sva_unbind_gpasid(struct iommu_domain *domain, -				struct device *dev, ioasid_t pasid); +extern int iommu_uapi_cache_invalidate(struct iommu_domain *domain, +				       struct device *dev, +				       struct iommu_cache_invalidate_info *inv_info); +extern int iommu_uapi_sva_bind_gpasid(struct iommu_domain *domain, +				      struct device *dev, struct iommu_gpasid_bind_data *data); +extern int iommu_uapi_sva_unbind_gpasid(struct iommu_domain *domain, +					struct device *dev, ioasid_t pasid);  extern struct iommu_domain *iommu_get_domain_for_dev(struct device *dev);  extern struct iommu_domain *iommu_get_dma_domain(struct device *dev);  extern int iommu_map(struct iommu_domain *domain, unsigned long iova, @@ -1032,21 +1032,22 @@ static inline int iommu_sva_get_pasid(struct iommu_sva *handle)  	return IOMMU_PASID_INVALID;  } -static inline int -iommu_cache_invalidate(struct iommu_domain *domain, -		       struct device *dev, -		       struct iommu_cache_invalidate_info *inv_info) +static inline int iommu_uapi_cache_invalidate(struct iommu_domain *domain, +					      struct device *dev, +					      struct iommu_cache_invalidate_info *inv_info)  {  	return -ENODEV;  } -static inline int iommu_sva_bind_gpasid(struct iommu_domain *domain, -				struct device *dev, struct iommu_gpasid_bind_data *data) + +static inline int iommu_uapi_sva_bind_gpasid(struct iommu_domain *domain, +					     struct device *dev, +					     struct iommu_gpasid_bind_data *data)  {  	return -ENODEV;  } -static inline int iommu_sva_unbind_gpasid(struct iommu_domain *domain, -					   struct device *dev, int pasid) +static inline int iommu_uapi_sva_unbind_gpasid(struct iommu_domain *domain, +					       struct device *dev, int pasid)  {  	return -ENODEV;  } | 
