diff options
| author | Chandra Mohan Sundar <chandramohan.explore@gmail.com> | 2025-09-01 21:59:19 +0530 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-09-02 16:39:29 -0700 |
| commit | 3586018d5c3da14addcd033b6da5a1a209a0992d (patch) | |
| tree | 468aed491f83d8dcb4d7ef20656b2f0cf4a02b48 | |
| parent | e2cf2d5baa09248d3d50b73522594b778388e3bc (diff) | |
net: macb: Validate the value of base_time properly
In macb_taprio_setup_replace(), the value of start_time is being
compared against zero which would never be true since start_time
is an unsigned value. Due to this there is a chance that an
incorrect config base time value can be used for computation.
Fix by checking the value of conf->base_time directly.
This issue was reported by static coverity analyzer.
Fixes: 89934dbf169e3 ("net: macb: Add TAPRIO traffic scheduling support")
Signed-off-by: Chandra Mohan Sundar <chandramohan.explore@gmail.com>
Reviewed-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
Link: https://patch.msgid.link/20250901162923.627765-1-chandramohan.explore@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/ethernet/cadence/macb_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 290d67da704d..e9b262a0223f 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4104,7 +4104,7 @@ static int macb_taprio_setup_replace(struct net_device *ndev, return -EINVAL; } - if (start_time < 0) { + if (conf->base_time < 0) { netdev_err(ndev, "Invalid base_time: must be 0 or positive, got %lld\n", conf->base_time); return -ERANGE; |