diff options
author | NeilBrown <neil@brown.name> | 2025-06-09 09:35:09 +1000 |
---|---|---|
committer | Steve French <stfrench@microsoft.com> | 2025-07-20 19:17:14 -0500 |
commit | d5fc1400a34b4ea5e8f2ce296ea12bf8c8421694 (patch) | |
tree | 89ba55d2f9a24caff70d9b914b972a1f83527194 /scripts/lib/kdoc/kdoc_parser.py | |
parent | a5dc90a9c355a30300ea4b4b25f0732270568d83 (diff) |
smb/server: avoid deadlock when linking with ReplaceIfExists
If smb2_create_link() is called with ReplaceIfExists set and the name
does exist then a deadlock will happen.
ksmbd_vfs_kern_path_locked() will return with success and the parent
directory will be locked. ksmbd_vfs_remove_file() will then remove the
file. ksmbd_vfs_link() will then be called while the parent is still
locked. It will try to lock the same parent and will deadlock.
This patch moves the ksmbd_vfs_kern_path_unlock() call to *before*
ksmbd_vfs_link() and then simplifies the code, removing the file_present
flag variable.
Signed-off-by: NeilBrown <neil@brown.name>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'scripts/lib/kdoc/kdoc_parser.py')
0 files changed, 0 insertions, 0 deletions