summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2011-09-06staging: hv: fix a kernel warning in netvsc_linkstatus_callback()Haiyang Zhang
netif_notify_peers() caused a kernel warning in netvsc_linkstatus_callback(), because netvsc_linkstatus_callback() is within IRQ context. So we move the first call to netif_notify_peers() into queued work as well, but with zero delay. In addition to "staging-next", this should also be back-ported to stable kernels 2.6.32 and later. Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: hv: convert dev_<loglevel> to netdev_<loglevel> in netvscHaiyang Zhang
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: hv: add newline to log messages in netvscHaiyang Zhang
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: hv: remove unnecessary includes in netvscHaiyang Zhang
hyperv.h is included by hyperv_net.h already, so no need to include it again in these C files. Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06Staging: hv: vmbus: Cleanup the code in process_chn_event()K. Y. Srinivasan
A channel in Hyper-V is equivalent to a device. Thus, a channel is persistent once it is presented to the guest, even if the driver managing this device is unloaded. By checking and invoking the driver specific callback function under the protection of the channel inbound_lock, we can properly deal with racing driver unloads since an unloading driver sets the callback to NULL under the protection of this inbound_lock. Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06Staging: hv: vmbus: Check for events before messagesK. Y. Srinivasan
The Windows team has informed us that on Windows guests on Hyper-V, they check for events before messages. They also recommended that we do the same. This patch addresses this. Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06Staging: hv: vmbus: Fix a bug in error handling in vmbus_bus_init()K. Y. Srinivasan
Fix a bug in error handling in vmbus_bus_init(). Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06Staging: hv: util: Deal with driver register failuresK. Y. Srinivasan
Properly deal with vmbus_driver_register() failures. Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: lirc_sasem: fix NULL pointer dereference in sasem_probeAlexey Khoroshilov
If any memory allocation failed, goto alloc_status_switch leads to mutex_unlock(&context->ctx_lock) while context is NULL. The patch moves alloc_status_switch to handle error conditions in correct way. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: lirc: fix mismatch in mutex lock-unlock in imon_probeAlexey Khoroshilov
If kzalloc failed for allocation of context, goto alloc_status_switch leads to unlock of unacquired driver_lock. The patch moves mutex_lock(&driver_lock) before allocation of context. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: fix rtl8192e build errorsRandy Dunlap
drivers/staging/rtl8192e/rtllib.h:2329: error: field 'wx_sem' has incomplete type drivers/staging/rtl8192e/rtllib.h:2330: error: field 'scan_sem' has incomplete type drivers/staging/rtl8192e/rtllib.h:2331: error: field 'ips_sem' has incomplete type drivers/staging/rtl8192e/rtllib_wx.c:267: error: implicit declaration of function 'down' drivers/staging/rtl8192e/rtllib_wx.c:290: error: implicit declaration of function 'up' Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete IF_DEF_ScaleLCDAaro Koskinen
Delete one more disabled feature. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete IF_DEF_PWDAaro Koskinen
Delete already disabled code paths. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete IF_DEF_OEMUtilAaro Koskinen
Delete already disabled code paths. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete Win9xDOSModeAaro Koskinen
Delete another useless flag. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete IF_DEF_VideoCaptureAaro Koskinen
Delete already disabled code paths. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete duplicated timing dataAaro Koskinen
Delete redundant timing data tables. Replace as follows: EnlargeTap4Timing ==> xgifb_tap4_timing NoScaleTap4Timing ==> xgifb_tap4_timing NTSCTap4Timing ==> xgifb_ntsc_525_tap4_timing YPbPr525iTap4Timing ==> xgifb_ntsc_525_tap4_timing YPbPr525pTap4Timing ==> xgifb_ntsc_525_tap4_timing Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete duplicated TV data tablesAaro Koskinen
Delete redundant TV data tables. Replace as follows: XGI_EPLCHTVDataPtr ==> xgifb_chrontel_tv XGI_EPLCHTVRegPtr ==> xgifb_chrontel_tv Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete duplicated LCD tableAaro Koskinen
XGI_EPLLCDCRT1Ptr_H and XGI_EPLLCDCRT1Ptr_V tables are identical. Replace as follows: XGI_EPLLCDCRT1Ptr_H ==> xgifb_epllcd_crt1 XGI_EPLLCDCRT1Ptr_V ==> xgifb_epllcd_crt1 Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete duplicated LCD dataAaro Koskinen
Delete duplicated LCD data tables. Replace as follows: XGI_ExtLCD1400x1050Data ==> xgifb_lcd_1400x1050 XGI_StLCD1400x1050Data ==> xgifb_lcd_1400x1050 XGI_ExtLCD1280x1024x75Data ==> xgifb_lcd_1280x1024x75 XGI_StLCD1280x1024x75Data ==> xgifb_lcd_1280x1024x75 XGI_ExtLCDDes1400x1050Data ==> xgifb_lcddes_1400x1050 XGI_StLCDDes1400x1050Data ==> xgifb_lcddes_1400x1050 XGI_ExtLCDDLDes1400x1050Data ==> xgifb_lcddldes_1400x1050 XGI_StLCDDLDes1400x1050Data ==> xgifb_lcddldes_1400x1050 XGI_ExtLCDDes1024x768x75Data ==> xgifb_lcddes_1024x768x75 XGI_StLCDDes1024x768x75Data ==> xgifb_lcddes_1024x768x75 XGI_ExtLCDDes1280x1024x75Data ==> xgifb_lcddes_1280x1024x75 XGI_StLCDDes1280x1024x75Data ==> xgifb_lcddes_1280x1024x75 XGI_ExtLCDDLDes1280x1024x75Data ==> xgifb_lcddldes_1280x1024x75 XGI_StLCDDLDes1280x1024x75Data ==> xgifb_lcddldes_1280x1024x75 Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete duplicated YFilter1 dataAaro Koskinen
PAL-M and PAL-N "YFilter1" tables are identical. Replace as follows: PALMYFilter1 ==> xgifb_palmn_yfilter1 PALNYFilter1 ==> xgifb_palmn_yfilter1 Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete duplicated YFilter2 dataAaro Koskinen
All four "YFilter2" tables are identical. Replace as follows: NTSCYFilter2 ==> xgifb_yfilter2; PALMYFilter2 ==> xgifb_yfilter2; PALNYFilter2 ==> xgifb_yfilter2; PALYFilter2 ==> xgifb_yfilter2; Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: do not initialize static data to 0Aaro Koskinen
Remove redundant initializations. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: eliminate #ifdef Tap4Aaro Koskinen
Eliminate #define Tap4 and related checks. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete commented-out routinesAaro Koskinen
Delete routines which have been commented out. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: refactor XGI_SetXG21LVDSPara() and XGI_SetXG27LVDSPara()Aaro Koskinen
The code is almost the same for XG21 and XG27, a single routine can cover both. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: refactor XGI_SetXG21LCD() and XGI_SetXG27LCD()Aaro Koskinen
The code is almost the same for XG21 and XG27, a single routine can cover both. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete redundant Chrontel TV dataAaro Koskinen
Delete redundant Chrontel TV data. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete support for Chrontel 7007 TV outputAaro Koskinen
IF_DEF_CH7007 is hard-coded to 0, so this is all just dead code that can be deleted. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete support for Chrontel 7005 TV outputAaro Koskinen
IF_DEF_CH7005 is hard-coded to 0, so this is all just dead code that can be deleted. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete support for Chrontel 7017 TV outputAaro Koskinen
IF_DEF_CH7017 is hard-coded to 0, so this is all just dead code that can be deleted. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete XGI_OpenCRTC()Aaro Koskinen
Delete redundant function. Also eliminates the following sparse warning: drivers/staging/xgifb/vb_setmode.c:8033:6: warning: symbol 'XGI_OpenCRTC' was not declared. Should it be static? Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: use common init for module and built-inAaro Koskinen
Use a common init function for module and built-in driver. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06stating: xgifb: update module parameter descriptionsAaro Koskinen
Remove incorrect/misleading text from parameter descriptions. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete all references to mode "none"Aaro Koskinen
Delete all references to mode "none". It should be handled like any other invalid mode. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: correct the default mode commentAaro Koskinen
According to the comment, the default mode should be 800x600x8 while the index points actually to 800x600x16. Change the comment and move the definition instead of changing the current behaviour. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: simplify default mode setupAaro Koskinen
The default mode is the same regardless of the display type, except for XG21/LCD which is determined dynamically. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: fail the probe if no supported LCD video mode foundAaro Koskinen
Fail the probe if the LCD resolution described in card firmware does not match any of the supported modes. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete duplicated default video mode setup codeAaro Koskinen
The code for determining the default video mode is unnecessarily duplicated in XGIfb_search_mode() and XGIfb_search_vesamode() functions. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: assume the default video mode also when moduleAaro Koskinen
The same default video mode should be assumed regardless if the driver is a module or not. This won't change the current behaviour, but it will simplify further changes. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: XGIfb_search_mode(): delete unreachable codeAaro Koskinen
XGIfb_search_mode() is always called with a valid string pointer. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: search video mode later in probeAaro Koskinen
When searching the video mode, some HW details needs to be known. Therefore it's not possible to do that reliably before probe(). Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: fix LVDS LCD resolution data setupAaro Koskinen
If the driver fails to get LVDS LCD data from the firmware, it falls back to using driver's hardcoded values. However, this is done too early in the probe. The selected video mode index is not yet known, and also in some cases it could be defaulting to -1 resulting in a read outside the array. Fix this by moving the array lookup after the video mode validation. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Reported-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: check and report invalid option valuesAaro Koskinen
Check option values with kstrtoul(). This will also eliminate some checkpatch warnings about simple_strtoul() usage. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: XGIfb_setup(): delete redundant assignmentAaro Koskinen
The global data is already initialized to zero. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: XGIfb_setup(): clean up driver messagesAaro Koskinen
Print options only if they are given. Delete other messages. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete "off" option handlingAaro Koskinen
It's possible to disable the built-in xgifb driver with the kernel command line option: video=xgifb:off This is already handled by the generic framebuffer layer (fb_get_options() will return TRUE resulting in init failure), so no need to process the option in the driver. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete duplicated codeAaro Koskinen
Delete redundant branches for "mode" and "vesa" options. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: fix ypan disable optionAaro Koskinen
Setting any of the FB options will disable ypan as a side effect. It should be disabled only by the "noypan" option. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-09-06staging: xgifb: delete unused module parameters and optionsAaro Koskinen
Delete parameters which have no effect. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>