summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-03-17netfilter: connlimit: use keyed locksFlorian Westphal
connlimit currently suffers from spinlock contention, example for 4-core system with rps enabled: + 20.84% ksoftirqd/2 [kernel.kallsyms] [k] _raw_spin_lock_bh + 20.76% ksoftirqd/1 [kernel.kallsyms] [k] _raw_spin_lock_bh + 20.42% ksoftirqd/0 [kernel.kallsyms] [k] _raw_spin_lock_bh + 6.07% ksoftirqd/2 [nf_conntrack] [k] ____nf_conntrack_find + 6.07% ksoftirqd/1 [nf_conntrack] [k] ____nf_conntrack_find + 5.97% ksoftirqd/0 [nf_conntrack] [k] ____nf_conntrack_find + 2.47% ksoftirqd/2 [nf_conntrack] [k] hash_conntrack_raw + 2.45% ksoftirqd/0 [nf_conntrack] [k] hash_conntrack_raw + 2.44% ksoftirqd/1 [nf_conntrack] [k] hash_conntrack_raw May allow parallel lookup/insert/delete if the entry is hashed to another slot. With patch: + 20.95% ksoftirqd/0 [nf_conntrack] [k] ____nf_conntrack_find + 20.50% ksoftirqd/1 [nf_conntrack] [k] ____nf_conntrack_find + 20.27% ksoftirqd/2 [nf_conntrack] [k] ____nf_conntrack_find + 5.76% ksoftirqd/1 [nf_conntrack] [k] hash_conntrack_raw + 5.39% ksoftirqd/2 [nf_conntrack] [k] hash_conntrack_raw + 5.35% ksoftirqd/0 [nf_conntrack] [k] hash_conntrack_raw + 2.00% ksoftirqd/1 [kernel.kallsyms] [k] __rcu_read_unlock Improved rx processing rate from ~35kpps to ~50 kpps. Reviewed-by: Jesper Dangaard Brouer <brouer@redhat.com> Signed-off-by: Florian Westphal <fw@strlen.de> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
2014-03-17KVM: s390: Optimize ucontrol pathChristian Borntraeger
Since commit 7c470539c95630c1f2a10f109e96f249730b75eb (s390/kvm: avoid automatic sie reentry) we will run through the C code of KVM on host interrupts instead of just reentering the guest. This will result in additional ucontrol exits (at least HZ per second). Let handle a 0 intercept in the kernel and dont return to userspace, even if in ucontrol mode. Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com> CC: stable@vger.kernel.org
2014-03-17KVM: s390: Removing untriggerable BUG_ONsDominik Dingel
The BUG_ON in kvm-s390.c is unreachable, as we get the vcpu per common code, which itself does this from the private_data field of the file descriptor, and there is no KVM_UNCREATE_VCPU. The __{set,unset}_cpu_idle BUG_ONs are not triggerable because the vcpu creation code already checks against KVM_MAX_VCPUS. Signed-off-by: Dominik Dingel <dingel@linux.vnet.ibm.com> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
2014-03-17can: mcp251x: Fix regulators operation without CONFIG_REGULATORAlexander Shiyan
If CONFIG_REGULATOR is not set, devm_regulator_get() returns NULL, so use IS_ERR_OR_NULL() macro for checks. Signed-off-by: Alexander Shiyan <shc_work@mail.ru> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
2014-03-17can: populate netdev::dev_id for udev discriminationChristopher R. Baker
My objective is to be able to totally discriminate CAN ports on multi-port cards via udev so as to rename them to semantically interesting/unique names for my system (e.g., "ecuCAN" and "auxCAN" instead of "can0" and "can1"). The following patch assigns the dev_id field to match the channel number on all multi-channel devices. I can only test my two-port Peak PCI card, but it works as expected: ATTRS{dev_id} now expresses the port number and my udev rules now unambiguously pick out and rename my individual CAN ports. Signed-off-by: Christopher R. Baker <cbaker@rec.ri.cmu.edu> Tested-by: Oliver Hartkopp <socketcan@hartkopp.net> [PEAK PCAN-USB pro and EMS PCMCIA] Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
2014-03-17can: Unify MTU settings for CAN interfacesOliver Hartkopp
CAN interfaces only support MTU values of 16 (CAN 2.0) and 72 (CAN FD). Setting the MTU to other values is pointless but it does not really hurt. With the introduction of the CAN FD support in drivers/net/can a new function to switch the MTU for CAN FD has been introduced. This patch makes use of this can_change_mtu() function to check for correct MTU settings also in legacy CAN (2.0) devices. Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
2014-03-16staging: bcm: Typedefs.h Fix "foo * bar" warning.Aybuke Ozdemir
This patch fixes these error messages found by checkpatch.pl: ERROR: "foo* bar" should be "foo *bar" Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: bcm: Typedefs.h Fix do not use // c99 comments.Aybuke Ozdemir
This patch fixes "do not use // C99 comments" errors in Typedefs.h Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: vt6656: power.c Fix line over 80 characters.Aybuke Ozdemir
Fix checkpatch.pl issue with line over 80 characters in power.c Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: nokia_h4p: nokia_fw-bcm.c Fix line over 80 characters.Aybuke Ozdemir
Fix checkpatch.pl issue with line over 80 characters in nokia_fw-bcm.c Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: winbond: Moved trailing statement to next lineGulsah Kose
Fix checkpatch.pl issues with trailing statement to next line in wb35reg.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: cxt1e1: Fix space prohibited between function name and open parenthesisGulsah Kose
Fix checkpatch.pl issues with space prohibited between function name and open parenthesis in libsbew.h Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: dgnc: Fix quoted string split across lines warningGulsah Kose
This patch fixes "quoted string split across lines warning" warning in dgnc_cls.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: line6: Fix line over 80 charactersGulsah Kose
Fix checkpatch.pl issue with line over 80 characters in midi.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging:keucr: Remove typedefsHimangi Saraogi
As suggested by Pablo, this patch uses a coccinelle script to remove the typedefs: typedef u8 BOOLEAN; <-- use "bool" instead. typedef u8 BYTE; <-- use "u8" typedef u8 *PBYTE; <-- use "u8 *" typedef u16 WORD; <-- use "u16" typedef u16 *PWORD; <-- use "u16 *" typedef u32 DWORD; <-- use "u32" typedef u32 *PDWORD; <-- use "u32 *" in common.h. The coccinelle script is: /* coccinelle script to remove typedefs. */ @remove_typedef@ @@ -typedef bool BOOLEAN; -typedef u8 BYTE; -typedef u8 *PBYTE; -typedef u16 WORD; -typedef u16 *PWORD; -typedef u32 DWORD; -typedef u32 *PDWORD; @fix_usage@ typedef BOOLEAN; @@ -BOOLEAN +bool @fix_usage1@ typedef BYTE; @@ -BYTE +u8 @fix_usage2@ typedef PBYTE; @@ -PBYTE +u8 * @fix_usage3@ typedef WORD; @@ -WORD +u16 @fix_usage4@ typedef PWORD; @@ -PWORD +u16 * @fix_usage5@ typedef DWORD; identifier f; @@ -DWORD +u32 @fix_usage6@ typedef PDWORD; @@ -PDWORD +u32 * Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Remove initialization of static variable in ↵Ana Rey
ieee80211/ieee80211_softmac.c Fix checkpatch.pl errors: ERROR: do not initialise statics to 0 or NULL Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Fix pointer declarations in ieee80211/ieee80211_softmac.cAna Rey
Fix pointer declarations as the codingStyle of the kernel recommends in ieee80211/ieee80211_softmac.c Fix checkpatch.pl errors: ERROR: "foo* bar" should be "foo *bar" ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Move trailing statement to next lineAna Rey
Move trailing statements to next line as the codingStyle of the kernel recommends. Fix checkpatch.pl errors: ERROR: trailing statements should be on next line Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Delete some innecesary whitespacesAna Rey
Delete some whitespaces (whitespace before a quoted newline, space at the start of a line and space before a tabs) as the codingStyle of the kernel recommends. Fix checkpatch.pl errors: WARNING: unnecessary whitespace before a quoted newline WARNING: please, no spaces at the start of a line WARNING: please, no space before tabs Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Add whitespaces around '&', '||' and '&&'Ana Rey
Add whitespaces around '&', '||' and '&&' as the codingStyle of the kernel recommends. Fix checkpatch.pl errors: ERROR: spaces required around that '||' (ctx:VxV) ERROR: spaces required around that '&&' (ctx:VxV) ERROR: need consistent spacing around '&' Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Add whitespaces around '+=' and '=='Ana Rey
Add whitespaces around '+=' and '==' and fix coding style in these lines as the codingStyle of the kernel recommends. Fix checkpatch.pl errors: ERROR: spaces required around that '+=' (ctx:VxV ERROR: spaces required around that '==' (ctx:VxW) Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Fix "code indent should use tabs where possible" errorAna Rey
Fix checkpatch.pl error: ERROR: code indent should use tabs where possible Also fix some problems with tabs in an if-statement. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Add whitespaces around commasAna Rey
Add whitespaces around commas and fix coding style in these lines as the codingStyle of the kernel recommends. Fix checkpatch.pl errors: ERROR: space required after that ',' Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Add whitespaces around '+', '-' and '='Ana Rey
Add whitespaces around '+', '-' and '=' as the codingStyle of the kernel recommends. Fix checkpatch.pl errors: ERROR: need consistent spacing around '+' ERROR: spaces required around that '=' (ctx:VxV) ERROR: need consistent spacing around '-' Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Delete spaces prohibited around semicolons, colons and ↵Ana Rey
exclamations Delete spaces prohibited before semicolon, before ':' and after '!' and fix coding style in these lines when It is necessary. Fix checkpàtch.pl error and warning messages: WARNING: space prohibited before semicolon ERROR: space prohibited before that ':' ERROR: space prohibited after that '!' Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Delete space prohibited after open parenthesis.Ana Rey
Delete space prohibited after open parenthesis and fix coding style in the lines changed when It is necessary Fix checkpatch.pl errors: ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Delete space prohibited between function name and open ↵Ana Rey
parenthesis Delete space prohibited between function name and open parenthesis and fix coding style in the lines changed when It is necessary Fix checkpatch.pl warning message: WARNING: space prohibited between function name and open parenthesis '('. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Add whitespaces in while and for structures.Ana Rey
Add a space required before the open parenthesis in while and for structures as the codingStyle of the kernel recommends. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Add whitespaces between 'if' and the condition.Ana Rey
Add a space required before the open parenthesis in conditional statements as the codingStyle of the kernel recommends. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Delete braces are not necessary in ↵Ana Rey
ieee80211/ieee80211_softmac.c Delete braces are not necessary for single statement blocks and fix coding style in these lines when It is necessary. Fix checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Add necessary whitespaces in while and do-while statements.Ana Rey
Fix whitespaces in do-while statements and while statements as the codingStyle of the kernel recommends in ieee80211/ieee80211_softmac.c Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Fix whitespace around else-statementsAna Rey
Fix whitespaces around else-statements and fix coding style in the lines when It is necessary as the codingStyle of the kernel recommends in ieee80211/ieee80211_softmac.c Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Fix whitespaces in if-statement.Ana Rey
Fix whitespaces around braces in if-statement as the codingStyle of the kernel recommends in ieee80211/ieee80211_softmac.c Also, fix coding style in these lines when It is necessary. Fix checkpatch.pl errors: ERROR: space required before the open brace '{' Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Remove unused functions 'rsn_authen_cipher_suite' and ↵Ana Rey
'ext_ieee80211_send_beacon_wq' Remove unused functions rsn_authen_cipher_suite() and ext_ieee80211_send_beacon_wq() from ieee80211_softmac.c. Fix sparse warnings: drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:27:11: warning: ‘rsn_authen_cipher_suite’ defined but not used [-Wunused-variable] drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:327:13: warning: ‘ext_ieee80211_send_beacon_wq’ defined but not used [-Wunused-function] Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Re-write if statement with comment lines inside.Ana Rey
Move comments from inside if conditionals to the lines above the if-statement. Also delete unnecessary whitespace in these lines. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Clean-up comment line styleAna Rey
Convert style of comments from C99-style to C89 and fix alignment in these lines as the CodingStyle recommends. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Remove unnecessary blank linesAna Rey
Remove unnecessary blank lines in ieee80211/ieee80211_softmac.c (and add some necessary blank lines). Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: rtl8187se: Delete commented codeAna Rey
Delete all commented code in ieee80211/ieee80211_softmac.c that are not necessary. Also, remove the unused variable referenced in the commented code. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: media/omap24xx/tcm825x.h removed warningUma Sharma
This patch removes the following checkpatch.pl warning in tcm825x.h Warning : missing space after return type Signed-off-by: Uma Sharma <uma.sharma523@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: media/msi3101/sdr-msi3101.c removed warningUma Sharma
This patch removes the following checkpatch.pl warning in sdr-msi3101.c Warning : Unnecessary space after function pointer name Signed-off-by: Uma Sharma <uma.sharma523@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: crystalhd: Fix no space before tabsGulsah Kose
This patch fixes no spaces before tabs warning in crystalhd_misc.h Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: go7007: go7007-v4l2.c Fix line over 80 characters.Aybuke Ozdemir
Fix checkpatch.pl issues with line over 80 characters in go7007-v4l2.c Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: octeon: ethernet-mdio.c Fix line over 80 characters.Aybuke Ozdemir
Fix checkpatch.pl issue with line over 80 characters in ethernet-mdio.c Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16Staging: bcm: Removed unreachable code line in Bcmchar.cEbru Akagunduz
This patch removes unreachable code line and unnecessary braces in Bcmchar.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Acked-by: Bob Copeland <me@bobcopeland.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16Staging: bcm: fix line over 80 characters in Bcmchar.cEbru Akagunduz
Fix checkpatch.pl issues with line over 80 characters in Bcmchar.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: removed space after return function in gdm_lte.hUma Sharma
This patch removes the following checkpatch.pl warning in gdm_lte.h Warning : space after return function Signed-off-by: Uma Sharma <uma.sharma523@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: nokia_h4p: Fix quoted string split across linesGulsah Kose
This patch fixes "quoted string split across lines warning" warning in nokia_core.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: frontier: Fix quoted string split across linesGulsah Kose
This patch fixes "quoted string split across lines warning" warning in alphatrack.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: lustre: Remove extern keyword from function prototypesAshley Smith
A function prototype is always a declaration and thus has "extern" prepended by default. Signed-off-by: Ashley Smith <ashley@eclipso.ch> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-16staging: silicom: Fix line over 80 characters.Gulsah Kose
Fix checkpatch.pl issues with line over 80 characters in bp_mod.h Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>