summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-02-25staging: wilc1000: handle_cfg_param: remove unnecessary whitespaceChaehyun Lim
This patch removes unnecessary whitespace before a quoted newline found by checkpatch WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: handle_cfg_param: fix line over 80 charactersChaehyun Lim
This patch fixes line over 80 characters found by checkpatch WARNING: line over 80 characters Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: handle_cfg_param: fix logical continuationsChaehyun Lim
This patch fixes logical continuations found by checkpatch CHECK: Logical continuations should be on the previous line Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: handle_cfg_param: rename wid_cntChaehyun Lim
wid_cnt variable is used as indicating array index of struct wid_list. This patch renames wid_cnt to i that makes more readability. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: handle_cfg_param: change data type of wid_cntChaehyun Lim
This patch changes data type of wid_cnt from u8 to int. This variable uses array index of struct wid_list so that it is better to use int type. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: handle_cfg_param: remove wrapper struct cfg_param_attrChaehyun Lim
This struct just wrap struct cfg_param_val. There is no other member except struct cfg_param_val. This patch remove struct cfg_param_attr, then struct cfg_param_val is renamed to struct cfg_param_attr. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: handle_set_mac_address: fix missing blank line after ↵Chaehyun Lim
declaration commit 31cc9885e7c7 ("staging: wilc1000: handle_set_mac_address: use kmemdup") introduces a new checkpatch warning, so this patch fixes it. WARNING: Missing a blank line after declarations FILE: drivers/staging/wilc1000/host_interface.c:430: Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25Staging: lustre: lov: Use list_for_each_entry instead of list_for_eachBhumika Goyal
Use list_for_each_entry instead of list_for_each and list_entry as it simplifies the code. Done using coccinelle: @@ type T,T2; identifier I1,I2; expression e1,e2; iterator name list_for_each_entry; iterator name list_for_each; @@ - T *I1; ... - list_for_each(I1,e1) + list_for_each_entry(I2,e1,e2) { ...when!=T *I1; - I2=list_entry(I1,T2,e2); ... } ...when!=I2; @@ type T,T2,T3; identifier I1,I2,I3; expression e1,e2; @@ - T *I1; + T3 *I3; ... - list_for_each(I1,e1) + list_for_each_entry(I3,e1,e2) { ...when!=T *I1; - T3 *I3=list_entry(I1,T2,e2); ... } ...when!=I3; Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: lustre: lustre: Remove unnecessary pair of braces {}Anchal Jain
For single statment of if not required a braces {}. Signed-off-by: Anchal Jain <anchalj109@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: lustre: libcfs: Remove comparison with zeroAmitoj Kaur Chawla
Replace comparison with zero with ! operator. Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: lustre: libcfs: Remove unnecessary bracesAmitoj Kaur Chawla
Removed unncessary braces from the if-else block to remove the following checkpatch.pl warning: WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: lustre: libcfs: Use swap() in cfs_hash_bd_order()Amitoj Kaur Chawla
Use swap() function instead of using a temporary variable for swapping two variables. The Coccinelle semantic patch used to make this change is as follows: //<smpl> @@ type T; T a,b,c; @@ - a = b; - b = c; - c = a; + swap(b, c); //<smpl> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: proper support of NFS anonymous dentriesDmitry Eremin
NFS can ask to encode dentries that are not connected to the root. The fix check for parent is NULL and encode a file handle accordingly. Reviewed-on: http://review.whamcloud.com/8347 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4231 Reviewed-by: Fan Yong <fan.yong@intel.com> Reviewed-by: James Simmons <uja.ornl@gmail.com> Reviewed-by: Jian Yu <jian.yu@intel.com> Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com> Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Acked-by: Jeff Layton <jlayton@poochiereds.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: lustre: llite: Remove IS_ERR testsAmitoj Kaur Chawla
ll_iget() has been modified to always return NULL in case of error and not a ERR_PTR. Consequently, remove unnecessary IS_ERR tests as now ll_iget() function can never return a ERR_PTR. Additionally, reinitialising root and inode to NULL has been removed since they have already been tested for the same. Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove unused members of struct ll_sb_infoOleg Drokin
ll_orphan_dentry_list and ll_conn_chain are not used and could be removed. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove commented out obd functionsOleg Drokin
obd_register_page_removal_cb, obd_unregister_page_removal_cb obd_register_lock_cancel_cb, obd_unregister_lock_cancel_cb Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove stray space before newline in messagesOleg Drokin
There were some messages in Lustre that ended with a space followed by a newline which is pointless, so remove the extra spaces. Found with checkpatch. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Fix indentation mistakesOleg Drokin
none look like bugs or bugs-inducing, mostly just off by a couple of spaces all around. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre/ptlrpc: Adjust comments to better conform to coding styleOleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre/osc: Adjust comments to better conform to coding styleOleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre/obdecho: Adjust comments to better conform to coding styleOleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre/obdclass: Adjust comments to better conform to coding styleOleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre/mgc: Adjust comments to better conform to coding styleOleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre/mdc: Adjust comments to better conform to coding styleOleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre/lov: Adjust comments to better conform to coding styleOleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre/lmv: Adjust comments to better conform to coding styleOleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre/llite: Adjust comments to better conform to coding styleOleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre/ldlm: Adjust comments to better conform to coding styleOleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre/lclient: Adjust comments to better conform to coding styleOleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre/fid: Adjust comments to better conform to coding styleOleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre/fld: Adjust comments to better conform to coding styleOleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre/include: Adjust comment styleOleg Drokin
This fixes most of the "Block comments use a trailing */ on a separate line" checkpatch warnings, also some slight reformats of structures or comments at places. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Reformat comments and structures in lustre_idl.hOleg Drokin
This file mostly contains various on the wire data and got significantly mangled in transition. This patch rectifies the situation somewhat. Also fixes the comment style for block comments. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove unused lli_open_count from struct ll_inode_infoOleg Drokin
Capabilities code was the only user and it is long gone. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: MAY_NOT_BLOCK is always defined, don't check for it.Oleg Drokin
Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove dead code in ldlm_lock_destroy_internalOleg Drokin
This code has been commented out since end of 2012, so it's clearly not needed here. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove last_rcvd-file related dataOleg Drokin
last_rcvd (last received) is a special server-side file on the Lustre FS that stores information about server filesystem and also list of connected clients and their state. There's no point in having any of tha ton the client, though. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove server data from struct obd_exportOleg Drokin
Despite it's name struct obd_export could exist on the client too (used for reverse exports), but all the actual server bits are not needed there, so could be dropped. This is mostly various target-related stuff. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove index file transfer structuresOleg Drokin
struct idx_info, struct lu_idxpage, lustre_swab_idx_info, request formats and related defines are all unused and could only happen for between-servers communications, so remove them from the client code. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: FMODE_READ and FMODE_WRITE are always defined in the kernelOleg Drokin
So no need to see if they are. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: S_DIRSYNC is always defined in kernelOleg Drokin
No need to check for it. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove lquota_glb_rec, lquota_slv_rec and lquota_acct_recOleg Drokin
These server-only structures and some supporting defines are unused on the client. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove unused struct quota_bodyOleg Drokin
It's only used for communications between servers. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove duplicated quota definesOleg Drokin
QUOTABLOCK_BITS, QUOTABLOCK_SIZE and toqb are only used on the server and are copied from kernel code anyway. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove *_CONNECT_SUPPORTED definesOleg Drokin
These defines are only used on the servers to determine what connect flags corresponding servers support: MDT_CONNECT_SUPPORTED OST_CONNECT_SUPPORTED MGS_CONNECT_SUPPORTED ECHO_CONNECT_SUPPORTED Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove server-only values from enum lu_dirent_attrsOleg Drokin
These values cannot be seen on the client so we probably should not even be aware of them on the client. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove FSF mailing address from GPL noticesOleg Drokin
This patch removes remaining several places that still had that extra paragraph included in Lustre code. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove server-side changelog definesOleg Drokin
CHANGELOG_MAGIC, CHANGELOG_MINMASK, CHANGELOG_ALLMASK, CHANGELOG_DEFMASK and CHANGELOG_USER_PREFIX are all unused on the client. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Get rid of C99 comments in lustre_idl.hOleg Drokin
lustre_idl.h contains various protocol data. In order to avoid reusal of values that might have meant something else in the past, the old no longer used values are commented out, convert the comments into regular comments from C99 where appropriate. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging/lustre: Remove lustre_build_version.hOleg Drokin
of the two macroses is contained the LUSTRE_RELEASE was unused and BUILD_VERSION is too generically named and was replaced with LUSTRE_VERSION_STRING with all the users (provided by lustre_ver.h) With in-kernel client the build version should be combined with kernel build information anyway. Signed-off-by: Oleg Drokin <green@linuxhacker.ru> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit (git 2.34.1) at 2025-09-17 03:31:50 +0000