summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-02-26ALSA: hda - Loop interrupt handling until really clearedTakashi Iwai
Currently the interrupt handler of HD-audio driver assumes that no irq update is needed while processing the irq. But in reality, it has been confirmed that the HW irq is issued even during the irq handling. Since we clear the irq status at the beginning, process the interrupt, then exits from the handler, the lately issued interrupt is left untouched without being properly processed. This patch changes the interrupt handler code to loop over the check-and-process. The handler tries repeatedly as long as the IRQ status are turned on, and either stream or CORB/RIRB is handled. For checking the stream handling, snd_hdac_bus_handle_stream_irq() returns a value indicating the stream indices bits. Other than that, the change is only in the irq handler itself. Reported-by: Libin Yang <libin.yang@linux.intel.com> Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2016-02-25staging: unisys: visorbus: Remove useless return variablesBhaktipriya Shridhar
This patch removes unnecessary return variables and compresses the return logic. The coccinelle script that finds and fixes this issue is: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(...); - return i; ) Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: unisys: visorbus: Remove unnecessary dev_set_drvdata()Amitoj Kaur Chawla
Unnecessary dev_set_drvdata() has been removed since the driver core clears the driver data to NULL after device release or on probe failure. There is no need to manually clear the device driver data to NULL. The Coccinelle semantic patch used to make this change is as follows: //<smpl> @@ struct device *dev; @@ - dev_set_drvdata(dev, NULL); //</smpl> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: unisys: iochannel.h add_phys_info needs u64 pfnDavid Kershner
The pfn field in the channel is 64 bits, the parameter being passed should be 64 bits as well. Signed-off-by: David Kershner <david.kershner@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: unisys: iochannel.h: fix inconsistent indentingDavid Kershner
Smatch complained about inconsistent indenting. This patch addresses it. Signed-off-by: David Kershner <david.kershner@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: unisys: return meaningful error for visorchipset_init()Benjamin Romer
The other error paths return meaningful error codes, except for the one when registering a device, which just returned -1. Let's return ENODEV when it fails to register instead. Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: unisys: clean up initiate_chipset_device_pause_resume()Benjamin Romer
Simplify this function by removing the goto in favor of handling errors immediately. Eliminate the vaguely-named variable x, and remove the unneeded initialization of rc. Lastly, provide meaningful error values to the callback function instead of just passing back a -1 for failure. Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: unisys: remove pointless init of rc in chipset_device_create()Benjamin Romer
The value of rc is set by calling a function, so there's no need to initialize it to -1, or anything at all. Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: unisys: get rid of goto in create_bus_instance()Benjamin Romer
Remove the unnecessary rc and goto messiness, and just handle freeing the memory before returning an error in the one place where that needs to happen. Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: unisys: cleanup rc -1 in create_visor_device()Benjamin Romer
Get rid of the rc = -1 initialization. Return a meaningful error on failure in the function, or, the rc from a called function if it fails. Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: unisys: remove goto in get_vbus_header_infoBenjamin Romer
Remove the rc, the = -1, and all the goto mess here and just return directly with a meaningful error number. The caller only cares about success/failure right now, that needs to be addressed in a later patch series. Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: unisys: fix return value for visorbus pci probeBenjamin Romer
Instead of returning -1, return -ENODEV when there is no probe function found for the device. Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: update TODOAaro Koskinen
Update TODO. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: avoid an overlong lineAaro Koskinen
Avoid an overlong line. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: move next pipe selection into a separate functionAaro Koskinen
Move next pipe selection into a separate function to avoid deep nesting. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: move isoc transfer handling into separate functionAaro Koskinen
Move isochronous transfer handling into a separate function to avoid deep indentation. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: move interrupt transfer handling into separate functionAaro Koskinen
Move bulk transfer handling into a separate function to avoid deep indentation. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: move bulk transfer handling into separate functionAaro Koskinen
Move bulk transfer handling into a separate function to avoid deep indentation. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: move control transfer handling into separate functionAaro Koskinen
Move control transfer handling into a separate function to avoid deep indentation. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: fold cvmx_usb_state into octeon_hcdAaro Koskinen
Fold cvmx_usb_state into octeon_hcd. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: rename STATUS_SUCCESS to STATUS_OKAaro Koskinen
Rename STATUS_SUCCESS to STATUS_OK. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: rename cvmx_usb_perform_complete to cvmx_usb_completeAaro Koskinen
Rename cvmx_usb_perform_complete to cvmx_usb_complete. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: rename cvmx_usb_complete to cvmx_usb_statusAaro Koskinen
Rename cvmx_usb_complete to cvmx_usb_status. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: simplify if statementAaro Koskinen
Simplify if statement to avoid deep nesting. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: pass transfer type to find_ready_pipeAaro Koskinen
Since we always search the same list, we can just pass the transfer type. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: eliminate redundant parameter from find_ready_pipeAaro Koskinen
current_frame always equals usb->frame_number. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: align split lines to match open parenthesisAaro Koskinen
Align split lines to match open parenthesis. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: octeon-usb: use preferred style for NULL comparisonAaro Koskinen
Use preferred coding style for NULL comparison. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: most: hdm-usb: Use macro DIV_ROUND_UPBhaktipriya Shridhar
The macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)). It clarifies the divisor calculations. This occurence was detected using the coccinelle script: @@ expression e1; expression e2; @@ ( - ((e1) + e2 - 1) / (e2) + DIV_ROUND_UP(e1,e2) | - ((e1) + (e2 - 1))/ (e2) + DIV_ROUND_UP(e1,e2) ) The macro CEILING was dropped altogether and has been replaced with DIV_ROUND_UP. Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25Staging: most: Do not print message if kzalloc() failed.Sandhya Bankar
Do not print message if kzalloc() failed. kzalloc() has its own messages. So no need to add extra one. Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: most: compress return logic into one lineEva Rachel Retuya
Eliminate local variable 'ret' and modify return statement to contain the value being returned directly instead of assigning it first to 'ret' and returning this variable. Coccinelle semantic patch used: @@ expression e, ret; @@ -ret = +return e; -return ret; Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: remove code for HOST_IF_MSG_DEL_ALL_RX_BA_SESSIONSAlison Schofield
The function that sent this message id was previously removed. Finish the cleanup by removing the call to the message handler, the message handler, and the #define. Signed-off-by: Alison Schofield <amsfield22@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: rename u16reason in disconnect_infoChaehyun Lim
This patch renames u16reason to reason to remove u16 prefix. There is no need to use prefix to show data type. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: rename struct tstrDisconnectNotifInfoChaehyun Lim
This patch renames struct tstrDisconnectNotifInfo to disconnect_info to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: rename u16ConnectStatus in struct connect_infoChaehyun Lim
This patch renames u16ConnectStatus to status to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: rename u16RespIEsLen in struct connect_infoChaehyun Lim
This patch renames u16RespIEsLen to resp_ies_len to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: rename pu8RespIEs in struct connect_infoChaehyun Lim
This patch renames pu8RespIEs to resp_ies to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: rename ReqIEsLen in struct connec_infoChaehyun Lim
This patch renames ReqIEsLen to req_ies_len to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: rename pu8ReqIEs in struct connect_infoChaehyun Lim
This patch renames pu8ReqIEs to req_ies to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: rename au8bssid in struct connect_infoChaehyun Lim
This patch renames au8bssid to bssid to remove au8 prefix in struct connect_info. There is no need to use prefix to show data type of this variable. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: rename struct tstrConnectInfoChaehyun Lim
This patch renames struct tstrConnectInfo to connect_info to avoid camelcase and removes typedef. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: Remove useless return variablesBhaktipriya Shridhar
This patch removes unnecessary return variables and compresses the return logic. The coccinelle script that finds and fixes this issue is: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(...); - return i; ) Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: wilc_wlan.c: remove multiple blank lineTony Cho
This patch removes the multiple blank line reported by checkpatch.pl. Signed-off-by: Tony Cho <tony.cho@atmel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: wilc_wlan.c: remove unnecessary blank linesTony Cho
This patch removes unnecessary blank lines found by checkpatch.pl. Signed-off-by: Tony Cho <tony.cho@atmel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: Revert "staging: wilc1000: remove spaces around '->'"Leo Kim
This reverts commit 6c2ab2398b88 ("staging: wilc1000: remove spaces around '->'"). It had applied from a incorrectly commit a1b56a4c5054 ("staging: wilc1000: wilc_wfi_cfgoperations.c: removes unnecessary log messages"). Signed-off-by: Leo Kim <leo.kim@atmel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: removes unnecessary retry 3 timesLeo Kim
This patch removes unnecessary retry 3 times and related variable. Actually the retry 3 times sentence, don't retry at all. Repeats conditions are that until read a chip-id and written a register. Signed-off-by: Leo Kim <leo.kim@atmel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: handle_cfg_param: remove unnecessary whitespaceChaehyun Lim
This patch removes unnecessary whitespace before a quoted newline found by checkpatch WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: handle_cfg_param: fix line over 80 charactersChaehyun Lim
This patch fixes line over 80 characters found by checkpatch WARNING: line over 80 characters Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: handle_cfg_param: fix logical continuationsChaehyun Lim
This patch fixes logical continuations found by checkpatch CHECK: Logical continuations should be on the previous line Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-25staging: wilc1000: handle_cfg_param: rename wid_cntChaehyun Lim
wid_cnt variable is used as indicating array index of struct wid_list. This patch renames wid_cnt to i that makes more readability. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit (git 2.34.1) at 2025-09-24 16:25:36 +0000