From b1f4213cfa2a21d07fc34519cb8c6c999f8784b1 Mon Sep 17 00:00:00 2001 From: Tom Rix Date: Mon, 21 Dec 2020 08:03:02 -0800 Subject: PNP: add printf attribute to log function Attributing the function allows the compiler to more thoroughly check the use of the function with -Wformat and similar flags. Signed-off-by: Tom Rix Signed-off-by: Rafael J. Wysocki --- drivers/pnp/interface.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pnp/interface.c b/drivers/pnp/interface.c index 187e4a1175b0..602c46893e83 100644 --- a/drivers/pnp/interface.c +++ b/drivers/pnp/interface.c @@ -33,6 +33,7 @@ struct pnp_info_buffer { typedef struct pnp_info_buffer pnp_info_buffer_t; +__printf(2, 3) static int pnp_printf(pnp_info_buffer_t * buffer, char *fmt, ...) { va_list args; -- cgit From 96228223933bf5ac920f93862c82449ec28247c0 Mon Sep 17 00:00:00 2001 From: Zheng Yongjun Date: Mon, 28 Dec 2020 21:50:26 +0800 Subject: PNP: pnpbios: Use DEFINE_SPINLOCK() for spinlock spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Signed-off-by: Zheng Yongjun Signed-off-by: Rafael J. Wysocki --- drivers/pnp/pnpbios/bioscalls.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pnp/pnpbios/bioscalls.c b/drivers/pnp/pnpbios/bioscalls.c index ba5cfc3dbe11..ddc6f2163c8e 100644 --- a/drivers/pnp/pnpbios/bioscalls.c +++ b/drivers/pnp/pnpbios/bioscalls.c @@ -72,7 +72,7 @@ __visible u32 pnp_bios_fault_esp; __visible u32 pnp_bios_fault_eip; __visible u32 pnp_bios_is_utter_crap = 0; -static spinlock_t pnp_bios_lock; +static DEFINE_SPINLOCK(pnp_bios_lock); /* * Support Functions @@ -473,7 +473,6 @@ void pnpbios_calls_init(union pnp_bios_install_struct *header) { int i; - spin_lock_init(&pnp_bios_lock); pnp_bios_callpoint.offset = header->fields.pm16offset; pnp_bios_callpoint.segment = PNP_CS16; -- cgit