diff options
| author | Russell King <rmk@arm.linux.org.uk> | 2016-06-06 17:59:13 +0100 |
|---|---|---|
| committer | Simon Horman <horms@verge.net.au> | 2016-06-08 09:21:52 +0900 |
| commit | 1c28b55604f388582253e7c7f07c48565a7213d7 (patch) | |
| tree | 8c1edabd313ee24c39136355779f6b516b518ff9 | |
| parent | cb9056e009a9e139c922f8643ef8dbe54b70edc4 (diff) | |
kdump: print mmap() offset in hex
When mmap() fails, printing a large decimal number is mostly
meaningless - it's not obvious what it means. Printing a hex number
is more obvious, because we can see whether it's over 32-bit, or not
page aligned.
Reviewed-by: Pratyush Anand <panand@redhat.com>
Signed-off-by: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: Simon Horman <horms@verge.net.au>
| -rw-r--r-- | kdump/kdump.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kdump/kdump.c b/kdump/kdump.c index 8f6f2df..de46d28 100644 --- a/kdump/kdump.c +++ b/kdump/kdump.c @@ -37,7 +37,7 @@ static void *map_addr(int fd, unsigned long size, off_t offset) result = mmap(0, len, PROT_READ, MAP_SHARED, fd, offset - map_offset); if (result == MAP_FAILED) { - fprintf(stderr, "Cannot mmap " DEV_MEM " offset: %llu size: %lu: %s\n", + fprintf(stderr, "Cannot mmap " DEV_MEM " offset: %#llx size: %lu: %s\n", (unsigned long long)offset, size, strerror(errno)); exit(5); } |