summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRussell King <rmk@armlinux.org.uk>2016-06-17 20:44:37 +0100
committerSimon Horman <horms@verge.net.au>2016-06-23 09:40:22 +0900
commitfe9b19d49be88e771a06ee4519d420db946ae3f3 (patch)
tree2185cf8561478afe23b1a045c9ba4890a2f6620f
parentbf759f2aa662199b1edad32a5192b787fafd5bf3 (diff)
arm: take account of TEXT_OFFSET for subsequent images
The ARM kexec code was not taking account of the 32k text offset when applying the size(s) of the kernel image. We need to take account of this so when we decide to place the initrd at 4x the compressed image length, it is appropriately placed. Signed-off-by: Russell King <rmk@armlinux.org.uk> Reviewed-by: Pratyush Anand <panand@redhat.com> Signed-off-by: Simon Horman <horms@verge.net.au>
-rw-r--r--kexec/arch/arm/kexec-zImage-arm.c12
1 files changed, 7 insertions, 5 deletions
diff --git a/kexec/arch/arm/kexec-zImage-arm.c b/kexec/arch/arm/kexec-zImage-arm.c
index aab0c86..297b7fd 100644
--- a/kexec/arch/arm/kexec-zImage-arm.c
+++ b/kexec/arch/arm/kexec-zImage-arm.c
@@ -340,7 +340,7 @@ static int setup_dtb_prop(char **bufp, off_t *sizep, int parentoffset,
int zImage_arm_load(int argc, char **argv, const char *buf, off_t len,
struct kexec_info *info)
{
- unsigned long base;
+ unsigned long base, kernel_base;
unsigned int atag_offset = 0x1000; /* 4k offset from memory start */
unsigned int extra_size = 0x8000; /* TEXT_OFFSET */
const char *command_line;
@@ -517,15 +517,17 @@ int zImage_arm_load(int argc, char **argv, const char *buf, off_t len,
if (base == ULONG_MAX)
return -1;
+ kernel_base = base + extra_size;
+
if (kexec_arm_image_size) {
/* If the image size was passed as command line argument,
* use that value for determining the address for initrd,
* atags and dtb images. page-align the given length.*/
- initrd_base = base + _ALIGN(kexec_arm_image_size, getpagesize());
+ initrd_base = kernel_base + _ALIGN(kexec_arm_image_size, getpagesize());
} else {
/* Otherwise, assume the maximum kernel compression ratio
* is 4, and just to be safe, place ramdisk after that */
- initrd_base = base + _ALIGN(len * 4, getpagesize());
+ initrd_base = kernel_base + _ALIGN(len * 4, getpagesize());
}
if (use_atags) {
@@ -617,9 +619,9 @@ int zImage_arm_load(int argc, char **argv, const char *buf, off_t len,
dtb_offset, dtb_length);
}
- add_segment(info, buf, len, base + extra_size, len);
+ add_segment(info, buf, len, kernel_base, len);
- info->entry = (void*)base + extra_size;
+ info->entry = (void*)kernel_base;
return 0;
}