diff options
author | Russell King <rmk+kernel@armlinux.org.uk> | 2020-03-13 10:48:32 +0000 |
---|---|---|
committer | Russell King (Oracle) <rmk+kernel@armlinux.org.uk> | 2021-06-07 11:26:45 +0100 |
commit | 5a7f14327bab317c8b744d7f675f859882fd8eea (patch) | |
tree | 381f3d5da6a5961442706fafabc7f1969b4616c6 /.mailmap | |
parent | fa950e0c8239b653250365f8d7c37fae74052e4f (diff) |
net: mtk_eth_soc: use resolved link config for PCS PHY
The SGMII PCS PHY needs to be updated with the link configuration in
the mac_link_up() call rather than in mac_config(). However,
mtk_sgmii_setup_mode_force() programs the SGMII block during
mac_config() when using 802.3z interface modes with the link
configuration.
Split that functionality from mtk_sgmii_setup_mode_force(), moving it
to a new mtk_sgmii_link_up() function, and call it from mac_link_up().
This does not look correct to me: 802.3z modes operate at a fixed
speed. The contents of mtk_sgmii_link_up() look more appropriate for
SGMII mode, but the original code definitely did not call
mtk_sgmii_setup_mode_force() for SGMII mode but only 802.3z mode.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Diffstat (limited to '.mailmap')
0 files changed, 0 insertions, 0 deletions