summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDave Airlie <airlied@gmail.com>2023-12-22 14:31:58 +1000
committerDave Airlie <airlied@redhat.com>2024-01-05 12:27:53 +1000
commit9c9dd22ba5d747cceee3d1b1757448b5c48ac705 (patch)
tree7b6eb208a011515e75c49ae4488b83b725f74f3b
parent4ae3a20102b20d1927737e1a78615386d58e194d (diff)
nouveau/gsp: always free the alloc messages on r535
Fixes a memory leak seen with kmemleak. Signed-off-by: Dave Airlie <airlied@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231222043308.3090089-10-airlied@gmail.com
-rw-r--r--drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
index 642ce0dd0faf..9ee58e2a0eb2 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c
@@ -605,8 +605,7 @@ r535_gsp_rpc_rm_alloc_push(struct nvkm_gsp_object *object, void *argv, u32 repc)
ret = repc ? rpc->params : NULL;
}
- if (ret)
- nvkm_gsp_rpc_done(gsp, rpc);
+ nvkm_gsp_rpc_done(gsp, rpc);
return ret;
}