summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJia He <hejianet@gmail.com>2016-09-30 11:29:01 +0800
committerDavid S. Miller <davem@davemloft.net>2016-09-30 01:50:44 -0400
commit7d64a94be2f9fadb1dd95742650f1fdbac69f25b (patch)
treeb3068f0c5f31adc9e33b814fad056400e74e98df
parent4a4857b1c81ef39a9dc719af6b498cd39d1c1eb0 (diff)
proc: Reduce cache miss in sctp_snmp_seq_show
This is to use the generic interfaces snmp_get_cpu_field{,64}_batch to aggregate the data by going through all the items of each cpu sequentially. Signed-off-by: Jia He <hejianet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/sctp/proc.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/net/sctp/proc.c b/net/sctp/proc.c
index ef8ba77a5bea..09e16c2b5c17 100644
--- a/net/sctp/proc.c
+++ b/net/sctp/proc.c
@@ -73,13 +73,17 @@ static const struct snmp_mib sctp_snmp_list[] = {
/* Display sctp snmp mib statistics(/proc/net/sctp/snmp). */
static int sctp_snmp_seq_show(struct seq_file *seq, void *v)
{
+ unsigned long buff[SCTP_MIB_MAX];
struct net *net = seq->private;
int i;
+ memset(buff, 0, sizeof(unsigned long) * SCTP_MIB_MAX);
+
+ snmp_get_cpu_field_batch(buff, sctp_snmp_list,
+ net->sctp.sctp_statistics);
for (i = 0; sctp_snmp_list[i].name != NULL; i++)
seq_printf(seq, "%-32s\t%ld\n", sctp_snmp_list[i].name,
- snmp_fold_field(net->sctp.sctp_statistics,
- sctp_snmp_list[i].entry));
+ buff[i]);
return 0;
}