summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorQuentin Monnet <quentin.monnet@netronome.com>2017-10-19 15:46:21 -0700
committerDavid S. Miller <davem@davemloft.net>2017-10-22 02:11:32 +0100
commit1d84487e2a2b98892c3dec7934604e9b76577aa6 (patch)
treedbc3328632eeabdae97f536ee958f20b6baa2f0c
parent1739c26da72c4170c86c368c75133adbb740efef (diff)
tools: bpftool: use err() instead of info() if there are too many insns
Make error messages and return codes more consistent. Specifically, replace the use of info() macro with err() when too many eBPF instructions are received to be dumped, given that bpftool returns with a non-null exit value in that case. Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Acked-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--tools/bpf/bpftool/prog.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c
index ede7957adcd9..6c03d2ea3f79 100644
--- a/tools/bpf/bpftool/prog.c
+++ b/tools/bpf/bpftool/prog.c
@@ -416,7 +416,7 @@ static int do_dump(int argc, char **argv)
}
if (*member_len > buf_size) {
- info("too many instructions returned\n");
+ err("too many instructions returned\n");
goto err_free;
}