diff options
authorColin Ian King <>2017-11-17 18:35:53 +0000
committerThomas Gleixner <>2017-11-23 20:03:58 +0100
commite9990d70e8a063a7b894c5cbb99f630a0f41200d (patch)
parent0e54705b0e01dcaf3eb2a496bb66d5f05012056b (diff)
irqchip/qcom: Fix u32 comparison with value less than zero
The comparison of u32 nregs being less than zero is never true since nregs is unsigned. Fix this by making nregs a signed integer. Fixes: f20cc9b00c7b ("irqchip/qcom: Add IRQ combiner driver") Signed-off-by: Colin Ian King <> Signed-off-by: Thomas Gleixner <> Cc: Marc Zyngier <> Cc: Cc: Jason Cooper <> Link:
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/irqchip/qcom-irq-combiner.c b/drivers/irqchip/qcom-irq-combiner.c
index 6aa3ea479214..f31265937439 100644
--- a/drivers/irqchip/qcom-irq-combiner.c
+++ b/drivers/irqchip/qcom-irq-combiner.c
@@ -238,7 +238,7 @@ static int __init combiner_probe(struct platform_device *pdev)
struct combiner *combiner;
size_t alloc_sz;
- u32 nregs;
+ int nregs;
int err;
nregs = count_registers(pdev);