summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoey Pabalinas <joeypabalinas@gmail.com>2018-01-01 10:40:14 -1000
committerHerbert Xu <herbert@gondor.apana.org.au>2018-01-12 23:03:05 +1100
commitda1729ce4866be266575a114208c7d5350bf310d (patch)
treee7105061b52aec718ef43b9e4611ed1b8bb1d7b1
parent7660b1fb367eb3723b48d3980451fc4f25a05021 (diff)
crypto: testmgr - change `guard` to unsigned char
When char is signed, storing the values 0xba (186) and 0xad (173) in the `guard` array produces signed overflow. Change the type of `guard` to static unsigned char to correct undefined behavior and reduce function stack usage. Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r--crypto/testmgr.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 29d7020b8826..44a85d4b3561 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -185,7 +185,7 @@ static int ahash_partial_update(struct ahash_request **preq,
char *state;
struct ahash_request *req;
int statesize, ret = -EINVAL;
- const char guard[] = { 0x00, 0xba, 0xad, 0x00 };
+ static const unsigned char guard[] = { 0x00, 0xba, 0xad, 0x00 };
req = *preq;
statesize = crypto_ahash_statesize(