summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2018-11-16 09:10:04 +0100
committerJens Axboe <axboe@kernel.dk>2018-11-16 09:17:00 -0700
commitb2101f655f8f6bd510154364e24d1cdba037133f (patch)
tree427c4be5d2bd82716cef1217e415260c26bba7fb
parenta50f9aec1ac713dd25f1b1b443d97aa2fc69f740 (diff)
ide: don't acquire queue lock in ide_pm_execute_rq
There is nothing we can synchronize against over a call to blk_queue_dying. Reviewed-by: Omar Sandoval <osandov@fb.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r--drivers/ide/ide-pm.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/ide/ide-pm.c b/drivers/ide/ide-pm.c
index 51fe10ac02fa..56690f523100 100644
--- a/drivers/ide/ide-pm.c
+++ b/drivers/ide/ide-pm.c
@@ -44,15 +44,12 @@ static int ide_pm_execute_rq(struct request *rq)
{
struct request_queue *q = rq->q;
- spin_lock_irq(&q->queue_lock);
if (unlikely(blk_queue_dying(q))) {
rq->rq_flags |= RQF_QUIET;
scsi_req(rq)->result = -ENXIO;
- spin_unlock_irq(&q->queue_lock);
blk_mq_end_request(rq, BLK_STS_OK);
return -ENXIO;
}
- spin_unlock_irq(&q->queue_lock);
blk_execute_rq(q, NULL, rq, true);
return scsi_req(rq)->result ? -EIO : 0;