summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Büsch <m@bues.ch>2021-05-15 21:02:52 +0200
committerKalle Valo <kvalo@codeaurora.org>2021-06-15 13:10:59 +0300
commit47ec636f7a25aa2549e198c48ecb6b1c25d05456 (patch)
tree076b2f119a119c6eb54b78083105713968ef9d79
parent77a0989baa427dbd242c5784d05a53ca3d197d43 (diff)
ssb: sdio: Don't overwrite const buffer if block_write fails
It doesn't make sense to clobber the const driver-side buffer, if a write-to-device attempt failed. All other SSB variants (PCI, PCMCIA and SoC) also don't corrupt the buffer on any failure in block_write. Therefore, remove this memset from the SDIO variant. Signed-off-by: Michael Büsch <m@bues.ch> Cc: stable@vger.kernel.org Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Link: https://lore.kernel.org/r/20210515210252.318be2ba@wiggum
-rw-r--r--drivers/ssb/sdio.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/ssb/sdio.c b/drivers/ssb/sdio.c
index 7fe0afb42234..66c5c2169704 100644
--- a/drivers/ssb/sdio.c
+++ b/drivers/ssb/sdio.c
@@ -411,7 +411,6 @@ static void ssb_sdio_block_write(struct ssb_device *dev, const void *buffer,
sdio_claim_host(bus->host_sdio);
if (unlikely(ssb_sdio_switch_core(bus, dev))) {
error = -EIO;
- memset((void *)buffer, 0xff, count);
goto err_out;
}
offset |= bus->sdio_sbaddr & 0xffff;