diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2015-12-21 14:58:52 +0100 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2015-12-26 22:28:32 +0100 |
| commit | 80776df4f53e8e2463e57b7b9bc13298c443a393 (patch) | |
| tree | 38fde8b54226b66383752bc222c5811d6a2de34d | |
| parent | c9d4ab030c6bdd3b7c7b0a9d4aeec7a8e1776fa5 (diff) | |
gpio: viperboard: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Cc: Lars Poeschel <poeschel@lemonage.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | drivers/gpio/gpio-viperboard.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-viperboard.c b/drivers/gpio/gpio-viperboard.c index 26e7edb74f42..7667e77dd52e 100644 --- a/drivers/gpio/gpio-viperboard.c +++ b/drivers/gpio/gpio-viperboard.c @@ -95,7 +95,7 @@ static int vprbrd_gpioa_get(struct gpio_chip *chip, /* if io is set to output, just return the saved value */ if (gpio->gpioa_out & (1 << offset)) - return gpio->gpioa_val & (1 << offset); + return !!(gpio->gpioa_val & (1 << offset)); mutex_lock(&vb->lock); |