diff options
author | Russell King <rmk+kernel@armlinux.org.uk> | 2019-11-05 10:34:39 +0000 |
---|---|---|
committer | Russell King <rmk+kernel@armlinux.org.uk> | 2020-02-28 12:36:59 +0000 |
commit | 6c564fbb3c8af4d463b196078976fe0d9485a9fc (patch) | |
tree | 66fb9b9752057a96ecb9339fbde15066b4c8909f | |
parent | 6d7f234524423d3ca14d5f00cb5052ef78ef5dbf (diff) |
net: phy: make phy_error() report which PHY has failed
phy_error() is called from phy_interrupt() or phy_state_machine(), and
uses WARN_ON() to print a backtrace. The backtrace is not useful when
reporting a PHY error.
However, a system may contain multiple ethernet PHYs, and phy_error()
gives no clue which one caused the problem.
Replace WARN_ON() with a call to phydev_err() so that we can see which
PHY had an error, and also inform the user that we are halting the PHY.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
-rw-r--r-- | drivers/net/phy/phy.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 2534b4169613..7708c1b18027 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -654,7 +654,7 @@ void phy_stop_machine(struct phy_device *phydev) */ static void phy_error(struct phy_device *phydev) { - WARN_ON(1); + phydev_err(phydev, "Error detected, halting PHY\n"); mutex_lock(&phydev->lock); phydev->state = PHY_HALTED; |