summaryrefslogtreecommitdiff
path: root/COPYING
diff options
context:
space:
mode:
authorStefan Assmann <sassmann@kpanic.de>2020-08-20 13:53:12 +0200
committerTony Nguyen <anthony.l.nguyen@intel.com>2020-09-09 15:06:24 -0700
commitb6f23d3817b965bcd6d72aab1f438ff6d16a0691 (patch)
tree30a9b1ebb79c1750ca25e3e4534b7ecaf53191c6 /COPYING
parente1e1b5356eb48dce4307f5cae10e4d6d5bd3df74 (diff)
i40e: always propagate error value in i40e_set_vsi_promisc()
The for loop in i40e_set_vsi_promisc() reports errors via dev_err() but does not propagate the error up the call chain. Instead it continues the loop and potentially overwrites the reported error value. This results in the error being recorded in the log buffer, but the caller might never know anything went the wrong way. To avoid this situation i40e_set_vsi_promisc() needs to temporarily store the error after reporting it. This is still not optimal as multiple different errors may occur, so store the first error and hope that's the main issue. Fixes: 37d318d7805f (i40e: Remove scheduling while atomic possibility) Reported-by: Michal Schmidt <mschmidt@redhat.com> Signed-off-by: Stefan Assmann <sassmann@kpanic.de> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions