diff options
author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-05-10 22:00:20 +0200 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2023-05-11 18:07:14 -0700 |
commit | f816b9829b19394d318e01953aa3b2721bca040d (patch) | |
tree | 9267ec78180582eb8ea180d17bd37d45ba08a466 /CREDITS | |
parent | ef1148d4487438a3408d6face2a8360d91b4af70 (diff) |
net: fec: Better handle pm_runtime_get() failing in .remove()
In the (unlikely) event that pm_runtime_get() (disguised as
pm_runtime_resume_and_get()) fails, the remove callback returned an
error early. The problem with this is that the driver core ignores the
error value and continues removing the device. This results in a
resource leak. Worse the devm allocated resources are freed and so if a
callback of the driver is called later the register mapping is already
gone which probably results in a crash.
Fixes: a31eda65ba21 ("net: fec: fix clock count mis-match")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20230510200020.1534610-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'CREDITS')
0 files changed, 0 insertions, 0 deletions