summaryrefslogtreecommitdiff
path: root/Documentation/EDID/1280x1024.S
diff options
context:
space:
mode:
authorChristoph Niedermaier <cniedermaier@dh-electronics.de>2018-11-05 09:48:34 +0100
committerJonathan Corbet <corbet@lwn.net>2018-11-06 07:36:18 -0700
commitd2f112a5681078aa2150f218074f76617fea4d74 (patch)
tree3df1cfe1b211827eb77446a0f9b7e9673b26c554 /Documentation/EDID/1280x1024.S
parent651022382c7f8da46cb4872a545ee1da6d097d2a (diff)
Docs/EDID: Fixed erroneous bits of XOFFSET, XPULSE, YOFFSET and YPULSE
The problem was found when EDID data sets for displays other than the provided samples were generated. The patch has no effect on the provided samples that still match the data used in drivers/gpu/drm/drm_edid_load.c. The provided samples use small values for XOFFSET, XPULSE, YOFFSET and YPULSE, where the error doesn't occur. This fix corrects the use of that values in case of high values, because the most significant bits were treated incorrectly. So in edid.S msbs4 should use bit 8 and 9 of XOFFSET and XPULS. For YOFFSET and YPULSE msbs4 should use bit 4 and 5. lsbs2 was introduced for a better overview, without functional change. Removing also the useless value 63 of all files, because it is added in the *.S description files and then it is subtracted in edid.S. Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.de> Reviewed-by: Carsten Emde <C.Emde@osadl.org> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Diffstat (limited to 'Documentation/EDID/1280x1024.S')
-rw-r--r--Documentation/EDID/1280x1024.S4
1 files changed, 2 insertions, 2 deletions
diff --git a/Documentation/EDID/1280x1024.S b/Documentation/EDID/1280x1024.S
index bd9bef2a65af..ce0e85be379e 100644
--- a/Documentation/EDID/1280x1024.S
+++ b/Documentation/EDID/1280x1024.S
@@ -31,8 +31,8 @@
#define YBLANK 42
#define XOFFSET 48
#define XPULSE 112
-#define YOFFSET (63+1)
-#define YPULSE (63+3)
+#define YOFFSET 1
+#define YPULSE 3
#define DPI 72
#define VFREQ 60 /* Hz */
#define TIMING_NAME "Linux SXGA"