summaryrefslogtreecommitdiff
path: root/Documentation/devicetree/bindings/mfd/max77693.txt
diff options
context:
space:
mode:
authorKrzysztof Kozlowski <krzk@kernel.org>2021-06-02 13:04:44 +0200
committerLee Jones <lee.jones@linaro.org>2021-11-05 14:40:06 +0000
commitf5f082eb0486365deab279bb226acdc3f08306b0 (patch)
tree5ca365bb93519e59ddc0a1fbaf8ad0f7cf4a2214 /Documentation/devicetree/bindings/mfd/max77693.txt
parent215e50b0864678e2fd765a8d57ae9aec713156c4 (diff)
mfd: max77693: Do not enforce (incorrect) interrupt trigger type
Interrupt line can be configured on different hardware in different way, even inverted. Therefore driver should not enforce specific trigger type - edge falling - but instead rely on Devicetree to configure it. The Maxim 77693 datasheet describes the interrupt line as active low with a requirement of acknowledge from the CPU therefore the edge falling is not correct. The interrupt line is shared between PMIC and RTC driver, so using level sensitive interrupt is here especially important to avoid races. With an edge configuration in case if first PMIC signals interrupt followed shortly after by the RTC, the interrupt might not be yet cleared/acked thus the second one would not be noticed. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Acked-by: Rob Herring <robh@kernel.org> Signed-off-by: Lee Jones <lee.jones@linaro.org> Link: https://lore.kernel.org/r/20210602110445.33536-3-krzysztof.kozlowski@canonical.com
Diffstat (limited to 'Documentation/devicetree/bindings/mfd/max77693.txt')
-rw-r--r--Documentation/devicetree/bindings/mfd/max77693.txt2
1 files changed, 1 insertions, 1 deletions
diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
index 0ced96e16c16..1032df14498b 100644
--- a/Documentation/devicetree/bindings/mfd/max77693.txt
+++ b/Documentation/devicetree/bindings/mfd/max77693.txt
@@ -139,7 +139,7 @@ Example:
compatible = "maxim,max77693";
reg = <0x66>;
interrupt-parent = <&gpx1>;
- interrupts = <5 2>;
+ interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
regulators {
esafeout@1 {