summaryrefslogtreecommitdiff
path: root/Documentation
diff options
context:
space:
mode:
authorVlad Buslov <vladbu@mellanox.com>2019-06-13 17:54:04 +0300
committerDavid S. Miller <davem@davemloft.net>2019-06-14 19:29:57 -0700
commit99815f5031db36414178f45e3009fb5f0e219dd4 (patch)
tree3315f9e1d75ea2f8a030260f42a4bb626b6d3593 /Documentation
parentf0c03ee0ec664e07e0ec1ead7091cbe53f0f321c (diff)
net: sched: flower: don't call synchronize_rcu() on mask creation
Current flower mask creating code assumes that temporary mask that is used when inserting new filter is stack allocated. To prevent race condition with data patch synchronize_rcu() is called every time fl_create_new_mask() replaces temporary stack allocated mask. As reported by Jiri, this increases runtime of creating 20000 flower classifiers from 4 seconds to 163 seconds. However, this design is no longer necessary since temporary mask was converted to be dynamically allocated by commit 2cddd2014782 ("net/sched: cls_flower: allocate mask dynamically in fl_change()"). Remove synchronize_rcu() calls from mask creation code. Instead, refactor fl_change() to always deallocate temporary mask with rcu grace period. Fixes: 195c234d15c9 ("net: sched: flower: handle concurrent mask insertion") Reported-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: Vlad Buslov <vladbu@mellanox.com> Tested-by: Jiri Pirko <jiri@mellanox.com> Acked-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions