summaryrefslogtreecommitdiff
path: root/Kbuild
diff options
context:
space:
mode:
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>2021-12-04 12:38:24 +0000
committerRussell King (Oracle) <rmk+kernel@armlinux.org.uk>2022-01-18 10:17:26 +0000
commit4a6332d33f6a9eb1edfdeadb3707c898d0221b9b (patch)
treef32230a29c76f5b9e25319941c11f16727c6c9d2 /Kbuild
parent45b4ec0637a3b5be7e7b27f94a567a349ed341f9 (diff)
net: sfp: fix high power modules without diag mode
Commit 7cfa9c92d0a3 ("net: sfp: avoid power switch on address-change modules") changed semantics for high power modules without diag mode. We repeatedly try to read the current power status from the non- existing 0x51 address, in the futile hope this failure is temporary: [ 8.856051] sfp sfp-eth3: module NTT 0000000000000000 rev 0000 sn 0000000000000000 dc 160408 [ 8.865843] mvpp2 f4000000.ethernet eth3: switched to inband/1000base-x link mode [ 8.873469] sfp sfp-eth3: Failed to read EEPROM: -5 [ 8.983251] sfp sfp-eth3: Failed to read EEPROM: -5 [ 9.103250] sfp sfp-eth3: Failed to read EEPROM: -5 Previously we assumed such modules were powered up in the correct mode, continuing without further configuration as long as the required power class was supported by the host. Restore this behaviour by detecting the lack of diagnostic address support prior to setting the module power or checking for the address change sequence. Fixes: 7cfa9c92d0a3 ("net: sfp: avoid power switch on address-change modules") Reported-by: 照山周一郎 <teruyama@springboard-inc.jp> Reported-by: Bjørn Mork <bjorn@mork.no> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Diffstat (limited to 'Kbuild')
0 files changed, 0 insertions, 0 deletions