summaryrefslogtreecommitdiff
path: root/MAINTAINERS
diff options
context:
space:
mode:
authorPavel Skripkin <paskripkin@gmail.com>2021-09-30 20:49:42 +0300
committerJakub Kicinski <kuba@kernel.org>2021-09-30 17:11:58 -0700
commit10eff1f5788b6ffac212c254e2f3666219576889 (patch)
tree73631262181740922c95130ca3ab1ec602db8723 /MAINTAINERS
parent4de593fb965fc2bd11a0b767e0c65ff43540a6e4 (diff)
Revert "net: mdiobus: Fix memory leak in __mdiobus_register"
This reverts commit ab609f25d19858513919369ff3d9a63c02cd9e2e. This patch is correct in the sense that we _should_ call device_put() in case of device_register() failure, but the problem in this code is more vast. We need to set bus->state to UNMDIOBUS_REGISTERED before calling device_register() to correctly release the device in mdiobus_free(). This patch prevents us from doing it, since in case of device_register() failure put_device() will be called 2 times and it will cause UAF or something else. Also, Reported-by: tag in revered commit was wrong, since syzbot reported different leak in same function. Link: https://lore.kernel.org/netdev/20210928092657.GI2048@kadam/ Acked-by: Yanfei Xu <yanfei.xu@windriver.com> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com> Link: https://lore.kernel.org/r/f12fb1faa4eccf0f355788225335eb4309ff2599.1633024062.git.paskripkin@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'MAINTAINERS')
0 files changed, 0 insertions, 0 deletions