summaryrefslogtreecommitdiff
path: root/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts
diff options
context:
space:
mode:
authorErmin Sunj <ermin.sunj@theobroma-systems.com>2023-09-07 17:17:15 +0200
committerHeiko Stuebner <heiko@sntech.de>2023-10-04 23:14:45 +0200
commit84fa1865edbb3800f3344e2a5bc73c187adf42d0 (patch)
treecc25d332a5067821f79b477f5992688c20268759 /arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts
parent0bb80ecc33a8fb5a682236443c1e740d5c917d1d (diff)
arm64: dts: rockchip: use codec as clock master on px30-ringneck-haikou
If the codec is not the clock master, the MCLK needs to be synchronous to both I2S_SCL ans I2S_LRCLK. We do not have that on Haikou, causing distorted audio. Before: Running an audio test script on Ringneck, 1kHz output sine wave is not stable and shows distortion. After: 10h audio test script loop failed only one time. That is 0.00014% failure rate. Cc: stable@vger.kernel.org Fixes: c484cf93f61b ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard") Signed-off-by: Ermin Sunj <ermin.sunj@theobroma-systems.com> Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> Link: https://lore.kernel.org/r/20230907151725.198347-1-jakob.unterwurzacher@theobroma-systems.com Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Diffstat (limited to 'arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts')
-rw-r--r--arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts6
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts
index 08a3ad3e7ae9..8792fae50257 100644
--- a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts
+++ b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts
@@ -68,15 +68,15 @@
simple-audio-card,format = "i2s";
simple-audio-card,name = "Haikou,I2S-codec";
simple-audio-card,mclk-fs = <512>;
+ simple-audio-card,frame-master = <&sgtl5000_codec>;
+ simple-audio-card,bitclock-master = <&sgtl5000_codec>;
- simple-audio-card,codec {
+ sgtl5000_codec: simple-audio-card,codec {
clocks = <&sgtl5000_clk>;
sound-dai = <&sgtl5000>;
};
simple-audio-card,cpu {
- bitclock-master;
- frame-master;
sound-dai = <&i2s0_8ch>;
};
};