diff options
| author | Mark Rutland <mark.rutland@arm.com> | 2021-11-29 13:06:49 +0000 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2021-12-01 00:06:44 +0100 |
| commit | e538c5849143a7f0aa97006cd45ce4c0c26d0744 (patch) | |
| tree | 58738b28e029566b02270b88fc53ef75b836d6b1 /arch/microblaze | |
| parent | 342b3808786518ced347f40b59bae68664e20007 (diff) | |
microblaze: Snapshot thread flags
Some thread flags can be set remotely, and so even when IRQs are disabled,
the flags can change under our feet. Generally this is unlikely to cause a
problem in practice, but it is somewhat unsound, and KCSAN will
legitimately warn that there is a data race.
To avoid such issues, a snapshot of the flags has to be taken prior to
using them. Some places already use READ_ONCE() for that, others do not.
Convert them all to the new flag accessor helpers.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Link: https://lore.kernel.org/r/20211129130653.2037928-8-mark.rutland@arm.com
Diffstat (limited to 'arch/microblaze')
| -rw-r--r-- | arch/microblaze/kernel/signal.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/microblaze/kernel/signal.c b/arch/microblaze/kernel/signal.c index fc61eb0eb8dd..23e8a9336a29 100644 --- a/arch/microblaze/kernel/signal.c +++ b/arch/microblaze/kernel/signal.c @@ -283,7 +283,7 @@ static void do_signal(struct pt_regs *regs, int in_syscall) #ifdef DEBUG_SIG pr_info("do signal: %p %d\n", regs, in_syscall); pr_info("do signal2: %lx %lx %ld [%lx]\n", regs->pc, regs->r1, - regs->r12, current_thread_info()->flags); + regs->r12, read_thread_flags()); #endif if (get_signal(&ksig)) { |