summaryrefslogtreecommitdiff
path: root/arch/mips/include/asm/edac.h
diff options
context:
space:
mode:
authorPaul Burton <paul.burton@mips.com>2018-11-08 20:14:38 +0000
committerPaul Burton <paul.burton@mips.com>2018-11-09 10:23:19 -0800
commit378ed6f0e3c525e3b12827e7b7fb0a078ee48a32 (patch)
tree766bb2bdd18f7aa7fce8a9ccb428cfcad8cf2feb /arch/mips/include/asm/edac.h
parent183b40f992c8f98082c4d72043ecdeba0e6a4367 (diff)
MIPS: Avoid using .set mips0 to restore ISA
We currently have 2 commonly used methods for switching ISA within assembly code, then restoring the original ISA. 1) Using a pair of .set push & .set pop directives. For example: .set push .set mips32r2 <some_insn> .set pop 2) Using .set mips0 to restore the ISA originally specified on the command line. For example: .set mips32r2 <some_insn> .set mips0 Unfortunately method 2 does not work with nanoMIPS toolchains, where the assembler rejects the .set mips0 directive like so: Error: cannot change ISA from nanoMIPS to mips0 In preparation for supporting nanoMIPS builds, switch all instances of method 2 in generic non-platform-specific code to use push & pop as in method 1 instead. The .set push & .set pop is arguably cleaner anyway, and if nothing else it's good to consistently use one method. Signed-off-by: Paul Burton <paul.burton@mips.com> Patchwork: https://patchwork.linux-mips.org/patch/21037/ Cc: linux-mips@linux-mips.org
Diffstat (limited to 'arch/mips/include/asm/edac.h')
-rw-r--r--arch/mips/include/asm/edac.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/mips/include/asm/edac.h b/arch/mips/include/asm/edac.h
index fc467767329b..c5d147744423 100644
--- a/arch/mips/include/asm/edac.h
+++ b/arch/mips/include/asm/edac.h
@@ -21,12 +21,13 @@ static inline void edac_atomic_scrub(void *va, u32 size)
*/
__asm__ __volatile__ (
+ " .set push \n"
" .set mips2 \n"
"1: ll %0, %1 # edac_atomic_scrub \n"
" addu %0, $0 \n"
" sc %0, %1 \n"
" beqz %0, 1b \n"
- " .set mips0 \n"
+ " .set pop \n"
: "=&r" (temp), "=" GCC_OFF_SMALL_ASM() (*virt_addr)
: GCC_OFF_SMALL_ASM() (*virt_addr));