summaryrefslogtreecommitdiff
path: root/arch
diff options
context:
space:
mode:
authorLee Duncan <lduncan@suse.com>2019-02-25 09:41:30 -0800
committerMartin K. Petersen <martin.petersen@oracle.com>2019-03-07 21:37:04 -0500
commita656183e6c58a3a4d818278afab522b30a17014c (patch)
treecbb8559e07d33ae4234aaae5196501af4e7e9e86 /arch
parentcf9efd5d92365696580a45e0351208eef0ea1562 (diff)
scsi: libiscsi: Hold back_lock when calling iscsi_complete_task
If there is an error queueing an iscsi command in iscsi_queuecommand(), for example if the transport fails to take the command in sessuin->tt->xmit_task(), then the error path can call iscsi_complete_task() without first aquiring the back_lock as required. This can lead to things like ITT pool can get corrupt, resulting in duplicate ITTs being sent out. The solution is to hold the back_lock around iscsi_complete_task() calls, and to add a little commenting to help others understand when back_lock must be held. Signed-off-by: Lee Duncan <lduncan@suse.com> Acked-by: Chris Leech <cleech@redhat.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'arch')
0 files changed, 0 insertions, 0 deletions