summaryrefslogtreecommitdiff
path: root/block/partitions
diff options
context:
space:
mode:
authorMauricio Faria de Oliveira <mfo@canonical.com>2018-07-25 22:46:29 -0300
committerJens Axboe <axboe@kernel.dk>2018-07-27 09:17:41 -0600
commitd43fdae7bac2def8c4314b5a49822cb7f08a45f1 (patch)
tree29ab95408a8e228d096dbe5d22740639ffd54d4e /block/partitions
parent14cb2c8a6c5dae57ee3e2da10fa3db2b9087e39e (diff)
partitions/aix: append null character to print data from disk
Even if properly initialized, the lvname array (i.e., strings) is read from disk, and might contain corrupt data (e.g., lack the null terminating character for strings). So, make sure the partition name string used in pr_warn() has the null terminating character. Fixes: 6ceea22bbbc8 ("partitions: add aix lvm partition support files") Suggested-by: Daniel J. Axtens <daniel.axtens@canonical.com> Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/partitions')
-rw-r--r--block/partitions/aix.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/block/partitions/aix.c b/block/partitions/aix.c
index 850cbd1860d4..903f3ed175d0 100644
--- a/block/partitions/aix.c
+++ b/block/partitions/aix.c
@@ -283,10 +283,14 @@ int aix_partition(struct parsed_partitions *state)
next_lp_ix += 1;
}
for (i = 0; i < state->limit; i += 1)
- if (lvip[i].pps_found && !lvip[i].lv_is_contiguous)
+ if (lvip[i].pps_found && !lvip[i].lv_is_contiguous) {
+ char tmp[sizeof(n[i].name) + 1]; // null char
+
+ snprintf(tmp, sizeof(tmp), "%s", n[i].name);
pr_warn("partition %s (%u pp's found) is "
"not contiguous\n",
- n[i].name, lvip[i].pps_found);
+ tmp, lvip[i].pps_found);
+ }
kfree(pvd);
}
kfree(n);