summaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorJean Sacren <sakiwit@gmail.com>2021-10-29 14:29:45 -0600
committerJens Axboe <axboe@kernel.dk>2021-10-30 09:34:14 -0600
commitef1661ba6d2e9c8eecd13ee04067bdcc59f7aac6 (patch)
tree993aa336586ce8ae954a4e46c187b2f586fb0a41 /block
parent9b84c629c90374498ab5825dede74a06ea1c775b (diff)
blk-mq: fix redundant check of !e expression
In the if branch, e is checked. In the else branch, ->dispatch_busy is merely a number and has no effect on !e. We should remove the check of !e since it is always true. Signed-off-by: Jean Sacren <sakiwit@gmail.com> Link: https://lore.kernel.org/r/20211029202945.3052-1-sakiwit@gmail.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
-rw-r--r--block/blk-mq-sched.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c
index c62b966dfaba..4a6789e4398b 100644
--- a/block/blk-mq-sched.c
+++ b/block/blk-mq-sched.c
@@ -497,7 +497,7 @@ void blk_mq_sched_insert_requests(struct blk_mq_hw_ctx *hctx,
* busy in case of 'none' scheduler, and this way may save
* us one extra enqueue & dequeue to sw queue.
*/
- if (!hctx->dispatch_busy && !e && !run_queue_async) {
+ if (!hctx->dispatch_busy && !run_queue_async) {
blk_mq_try_issue_list_directly(hctx, list);
if (list_empty(list))
goto out;