diff options
author | Rabin Vincent <rabinv@axis.com> | 2016-05-18 12:47:31 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-05-20 10:50:16 -0700 |
commit | 185be5aef1739fff0298f59b54f2ef7ccf5a849d (patch) | |
tree | b2135e78203ef0eb6b8bb6495c387a93aeff749e /certs | |
parent | 52103b70e13ae1381020b5a9fa15824a9b35baeb (diff) |
phy: fix crash in fixed_phy_add()
Since e7f4dc3536a ("mdio: Move allocation of interrupts into core"),
platforms which call fixed_phy_add() before fixed_mdio_bus_init() is
called (for example, because the platform code and the fixed_phy driver
use the same initcall level) crash in fixed_phy_add() since the
->mii_bus is not allocated.
Also since e7f4dc3536a, these interrupts are initalized to polling by
default. The few (old) platforms which directly use fixed_phy_add()
from their platform code all pass PHY_POLL for the irq argument, so we
can keep these platforms not crashing by simply not attempting to set
the irq if PHY_POLL is passed.
Also, even if problems have not been reported on more modern platforms
which used fixed_phy_register() from drivers' probe functions, we return
-EPROBE_DEFER if the MDIO bus is not yet registered so that the probe is
retried later.
Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
Signed-off-by: Rabin Vincent <rabinv@axis.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'certs')
0 files changed, 0 insertions, 0 deletions