summaryrefslogtreecommitdiff
path: root/drivers/android
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2024-04-30 09:27:48 +1000
committerMichael S. Tsirkin <mst@redhat.com>2024-07-09 08:42:40 -0400
commit7ad4723976672b7d359403a555e0ce5c75529153 (patch)
treefacd5a3970b5ffa5df8f945ef5312ea1006314e9 /drivers/android
parentfdba68d2adf8d9ae680e23e8b8ba79330baa45bc (diff)
vhost: move smp_rmb() into vhost_get_avail_idx()
All callers of vhost_get_avail_idx() use smp_rmb() to order the available ring entry read and avail_idx read. Make vhost_get_avail_idx() call smp_rmb() itself whenever the avail_idx is accessed. This way, the callers don't need to worry about the memory barrier. As a side benefit, we also validate the index on all paths now, which will hopefully help prevent/catch earlier future bugs. Note that current code is inconsistent in how the errors are handled. They are treated as an empty ring in some places, but as non-empty ring in other places. This patch doesn't attempt to change the existing behaviour. No functional change intended. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Gavin Shan <gshan@redhat.com> Acked-by: Will Deacon <will@kernel.org> Message-Id: <20240429232748.642356-1-gshan@redhat.com>
Diffstat (limited to 'drivers/android')
0 files changed, 0 insertions, 0 deletions