summaryrefslogtreecommitdiff
path: root/drivers/ata/pata_bf54x.c
diff options
context:
space:
mode:
authorTejun Heo <htejun@gmail.com>2008-04-24 10:52:44 +0900
committerJeff Garzik <jgarzik@redhat.com>2008-04-24 23:42:47 -0400
commit8e5443a09851d99084098ecc4066805aa2610d92 (patch)
tree8a8046ac3eef4bf1f817451097d540eecbf0c488 /drivers/ata/pata_bf54x.c
parent2b4221bb545899b05872e7b51f55567c10b3894b (diff)
sata_sis: SCR accessors return -EINVAL when requested SCR isn't available
sis_scr_cfg_read() can't access SError and was incorrectly returning -1 instead of -EINVAL. This went unnoticed because SError used to be cleared in @postreset() and it didn't care about how scr_read() failed but commit ac371987 moved SError clearing into sata_link_resume() and SCR access failure other than -EINVAL is considered an error condition and exposes the incorrect return value bug as detection failure. Fix it. Also, scsi_scr_cfg_write() was incorrectly returning 0 after it ignored the request to write to SError. Make it also return -EINVAL. This was bisected and reported by Patrick McHardy. Signed-off-by: Tejun Heo <htejun@gmail.com> Cc: Patrick McHardy <kaber@trash.net> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/ata/pata_bf54x.c')
0 files changed, 0 insertions, 0 deletions