diff options
| author | Joe Perches <joe@perches.com> | 2018-05-09 08:15:48 -0700 |
|---|---|---|
| committer | Corey Minyard <cminyard@mvista.com> | 2018-09-18 16:15:33 -0500 |
| commit | 25880f7d61a4f2fdda29cadae55985431df82c5c (patch) | |
| tree | 49dcde8db432165b4959deb11d1ecc860edd04e4 /drivers/char/ipmi/ipmi_si_pci.c | |
| parent | 445e2cbda928a3523c1c1da76788d19df52611c8 (diff) | |
ipmi: Use more common logging styles
Add and use #define pr_fmt/dev_fmt, and remove #define PFX
This also prefixes some messages that were not previously prefixed.
Miscellanea:
o Convert printk(KERN_<level> to pr_<level>(
o Use %s, __func__ where appropriate
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Diffstat (limited to 'drivers/char/ipmi/ipmi_si_pci.c')
| -rw-r--r-- | drivers/char/ipmi/ipmi_si_pci.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/char/ipmi/ipmi_si_pci.c b/drivers/char/ipmi/ipmi_si_pci.c index bdba12852a90..5eaa850ce455 100644 --- a/drivers/char/ipmi/ipmi_si_pci.c +++ b/drivers/char/ipmi/ipmi_si_pci.c @@ -4,12 +4,13 @@ * * Handling for IPMI devices on the PCI bus. */ + +#define pr_fmt(fmt) "ipmi_pci: " fmt + #include <linux/module.h> #include <linux/pci.h> #include "ipmi_si.h" -#define PFX "ipmi_pci: " - static bool pci_registered; static bool si_trypci = true; @@ -40,8 +41,7 @@ static int ipmi_pci_probe_regspacing(struct si_sm_io *io) for (regspacing = DEFAULT_REGSPACING; regspacing <= 16;) { io->regspacing = regspacing; if (io->io_setup(io)) { - dev_err(io->dev, - "Could not setup I/O space\n"); + dev_err(io->dev, "Could not setup I/O space\n"); return DEFAULT_REGSPACING; } /* write invalid cmd */ @@ -126,7 +126,7 @@ static int ipmi_pci_probe(struct pci_dev *pdev, io.dev = &pdev->dev; dev_info(&pdev->dev, "%pR regsize %d spacing %d irq %d\n", - &pdev->resource[0], io.regsize, io.regspacing, io.irq); + &pdev->resource[0], io.regsize, io.regspacing, io.irq); rv = ipmi_si_add_smi(&io); if (rv) @@ -161,7 +161,7 @@ void ipmi_si_pci_init(void) if (si_trypci) { int rv = pci_register_driver(&ipmi_pci_driver); if (rv) - pr_err(PFX "Unable to register PCI driver: %d\n", rv); + pr_err("Unable to register PCI driver: %d\n", rv); else pci_registered = true; } |