diff options
| author | Tianjia Zhang <tianjia.zhang@linux.alibaba.com> | 2020-10-05 22:52:12 +0800 |
|---|---|---|
| committer | Corey Minyard <cminyard@mvista.com> | 2020-10-05 13:30:51 -0500 |
| commit | 8fe7990ceda8597e407d06bffc4bdbe835a93ece (patch) | |
| tree | 9fc39a700cff5f57f3f5a2e8c8d51f84dec540b2 /drivers/char | |
| parent | c011410d9145695c460567fa5ba1ade6a7b16f06 (diff) | |
ipmi_si: Fix wrong return value in try_smi_init()
On an error exit path, a negative error code should be returned
instead of a positive return value.
Fixes: 90b2d4f15ff7 ("ipmi_si: Remove hacks for adding a dummy platform devices")
Cc: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Message-Id: <20201005145212.84435-1-tianjia.zhang@linux.alibaba.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Diffstat (limited to 'drivers/char')
| -rw-r--r-- | drivers/char/ipmi/ipmi_si_intf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index 0b3dbc7e39fd..5eac94cf4ff8 100644 --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c @@ -1980,7 +1980,7 @@ static int try_smi_init(struct smi_info *new_smi) /* Do this early so it's available for logs. */ if (!new_smi->io.dev) { pr_err("IPMI interface added with no device\n"); - rv = EIO; + rv = -EIO; goto out_err; } |