diff options
| author | Nathan Chancellor <nathan@kernel.org> | 2022-01-07 11:33:03 -0700 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2022-01-07 16:08:07 -0800 |
| commit | 4e31bfa37662f72e8e7e3ae46eb5f845a5854229 (patch) | |
| tree | 206586996e700f3a2a2254075d5574464c45c070 /drivers/clk/visconti | |
| parent | 70faf946ad975c64efb2eb809f9139f304a494b0 (diff) | |
clk: visconti: Remove pointless NULL check in visconti_pll_add_lookup()
Clang warns:
drivers/clk/visconti/pll.c:292:20: warning: address of array 'ctx->clk_data.hws' will always evaluate to 'true' [-Wpointer-bool-conversion]
if (ctx->clk_data.hws && id)
~~~~~~~~~~~~~~^~~ ~~
1 warning generated.
This array cannot be NULL if ctx is not NULL, which is allocated in
visconti_init_pll(), so just remove the check, which matches other clk
drivers.
Fixes: b4cbe606dc36 ("clk: visconti: Add support common clock driver and reset driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1564
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20220107183303.2337676-1-nathan@kernel.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers/clk/visconti')
| -rw-r--r-- | drivers/clk/visconti/pll.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clk/visconti/pll.c b/drivers/clk/visconti/pll.c index 3b6e88bb73d5..a2398bc6c6e4 100644 --- a/drivers/clk/visconti/pll.c +++ b/drivers/clk/visconti/pll.c @@ -289,7 +289,7 @@ static void visconti_pll_add_lookup(struct visconti_pll_provider *ctx, struct clk_hw *hw_clk, unsigned int id) { - if (ctx->clk_data.hws && id) + if (id) ctx->clk_data.hws[id] = hw_clk; } |