summaryrefslogtreecommitdiff
path: root/drivers/dma/milbeaut-hdmac.c
diff options
context:
space:
mode:
authorLen Baker <len.baker@gmx.com>2021-09-04 16:58:13 +0200
committerVinod Koul <vkoul@kernel.org>2021-10-25 12:12:13 +0530
commitfe14c67267886e3af3c377a7bee4e6f915778636 (patch)
tree0a20abc20a5a6d55710f0aa11bd061a30a5ac350 /drivers/dma/milbeaut-hdmac.c
parentdbe3c54e71051b50a4aa863502368000d3e7701f (diff)
dmaengine: milbeaut-hdmac: Prefer kcalloc over open coded arithmetic
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors. So, use the purpose specific kcalloc() function instead of the argument size * count in the kzalloc() function. [1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments Signed-off-by: Len Baker <len.baker@gmx.com> Link: https://lore.kernel.org/r/20210904145813.5161-1-len.baker@gmx.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/milbeaut-hdmac.c')
-rw-r--r--drivers/dma/milbeaut-hdmac.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/milbeaut-hdmac.c b/drivers/dma/milbeaut-hdmac.c
index a8cfb59f6efe..1b0a95892627 100644
--- a/drivers/dma/milbeaut-hdmac.c
+++ b/drivers/dma/milbeaut-hdmac.c
@@ -269,7 +269,7 @@ milbeaut_hdmac_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
if (!md)
return NULL;
- md->sgl = kzalloc(sizeof(*sgl) * sg_len, GFP_NOWAIT);
+ md->sgl = kcalloc(sg_len, sizeof(*sgl), GFP_NOWAIT);
if (!md->sgl) {
kfree(md);
return NULL;