summaryrefslogtreecommitdiff
path: root/drivers/edac
diff options
context:
space:
mode:
authorWei Yongjun <weiyongjun1@huawei.com>2020-01-15 15:03:03 +0000
committerBorislav Petkov <bp@suse.de>2020-01-17 01:37:51 +0100
commit6cd18453b68942913fd3b1913b707646e544c2ac (patch)
tree414cf9c063d9db1d4bbed83e0f9d8c089ffe04e0 /drivers/edac
parenta651c6c64431765c7a833e37dae5b135622bdf04 (diff)
EDAC/sifive: Fix return value check in ecc_register()
In case of error, the function edac_device_alloc_ctl_info() returns a NULL pointer, not ERR_PTR(). Replace the IS_ERR() test in the return value check with a NULL test. Fixes: 91abaeaaff35 ("EDAC/sifive: Add EDAC platform driver for SiFive SoCs") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Signed-off-by: Borislav Petkov <bp@suse.de> Link: https://lkml.kernel.org/r/20200115150303.112627-1-weiyongjun1@huawei.com
Diffstat (limited to 'drivers/edac')
-rw-r--r--drivers/edac/sifive_edac.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/edac/sifive_edac.c b/drivers/edac/sifive_edac.c
index 413cdb4a591d..bb9ceeaf29bf 100644
--- a/drivers/edac/sifive_edac.c
+++ b/drivers/edac/sifive_edac.c
@@ -54,8 +54,8 @@ static int ecc_register(struct platform_device *pdev)
p->dci = edac_device_alloc_ctl_info(0, "sifive_ecc", 1, "sifive_ecc",
1, 1, NULL, 0,
edac_device_alloc_index());
- if (IS_ERR(p->dci))
- return PTR_ERR(p->dci);
+ if (!p->dci)
+ return -ENOMEM;
p->dci->dev = &pdev->dev;
p->dci->mod_name = "Sifive ECC Manager";