summaryrefslogtreecommitdiff
path: root/drivers/gpio/gpio-exar.c
diff options
context:
space:
mode:
authorKangjie Lu <kjlu@umn.edu>2019-03-08 22:07:57 -0600
committerBartosz Golaszewski <bgolaszewski@baylibre.com>2019-03-22 16:48:39 +0100
commit7ecced0934e574b528a1ba6c237731e682216a74 (patch)
tree21090e6781fdea12fceb2d6880ce79588f09f554 /drivers/gpio/gpio-exar.c
parent9e98c678c2d6ae3a17cb2de55d17f69dddaa231b (diff)
gpio: exar: add a check for the return value of ida_simple_get fails
ida_simple_get may fail and return a negative error number. The fix checks its return value; if it fails, go to err_destroy. Cc: <stable@vger.kernel.org> Signed-off-by: Kangjie Lu <kjlu@umn.edu> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Diffstat (limited to 'drivers/gpio/gpio-exar.c')
-rw-r--r--drivers/gpio/gpio-exar.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c
index 0ecd2369c2ca..a09d2f9ebacc 100644
--- a/drivers/gpio/gpio-exar.c
+++ b/drivers/gpio/gpio-exar.c
@@ -148,6 +148,8 @@ static int gpio_exar_probe(struct platform_device *pdev)
mutex_init(&exar_gpio->lock);
index = ida_simple_get(&ida_index, 0, 0, GFP_KERNEL);
+ if (index < 0)
+ goto err_destroy;
sprintf(exar_gpio->name, "exar_gpio%d", index);
exar_gpio->gpio_chip.label = exar_gpio->name;