diff options
| author | Douglas Anderson <dianders@chromium.org> | 2021-07-30 08:46:00 -0700 |
|---|---|---|
| committer | Sam Ravnborg <sam@ravnborg.org> | 2021-07-31 20:02:59 +0200 |
| commit | 64c0274fb15c1daf6618f5f4d2b3ed80822e5e8d (patch) | |
| tree | 2c5c8b9220ee4627b6a60e6c5ec1bb753d900321 /drivers/gpu/drm/bridge | |
| parent | 676f11b5a4a06281420070ffdbb09c05851fa819 (diff) | |
drm/dp: Don't zero PWMGEN_BIT_COUNT when driver_pwm_freq_hz not specified
The function drm_edp_backlight_init() is defined such that the
"driver_pwm_freq_hz" parameter is optional--it's 0 if you don't want
to futz with it. If you follow this variable through, you'll find out
that if it's 0 we won't ever set the "bl->pwmgen_bit_count", leaving
it as 0.
That means that before using it in drm_edp_backlight_enable() we need
to check to see if it's non-zero.
Programming this field to zero was confusing the panel I tested with
(Samsung ATNA33XC20). The backlight still worked somewhat but the
brightness values didn't correspond to what they should have been.
Fixes: 867cf9cd73c3 ("drm/dp: Extract i915's eDP backlight code into DRM helpers")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210730084534.v2.1.If017efce7116ae8ba015ed7def840c390a0e0c77@changeid
Diffstat (limited to 'drivers/gpu/drm/bridge')
0 files changed, 0 insertions, 0 deletions