diff options
author | Jani Nikula <jani.nikula@intel.com> | 2023-01-17 14:33:06 +0200 |
---|---|---|
committer | Jani Nikula <jani.nikula@intel.com> | 2023-01-25 13:51:51 +0200 |
commit | 9bd5de4abd444fd4466150091d4bb38ef2052e8d (patch) | |
tree | 6d3eb6b2e9b6d0d1704ea67b118fc99d05c3732a /drivers/gpu/drm/i915/i915_driver.c | |
parent | 31395fba97f2bbe33237125e2dc97b4c998d0b68 (diff) |
drm/i915: add gmch substruct to struct drm_i915_private
Group the GMCH related members together.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/c10c8f16cb5d12041e009f788bd9810225d6962d.1673958757.git.jani.nikula@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/i915_driver.c')
-rw-r--r-- | drivers/gpu/drm/i915/i915_driver.c | 58 |
1 files changed, 29 insertions, 29 deletions
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c index c1e427ba57ae..59cbc24cda6c 100644 --- a/drivers/gpu/drm/i915/i915_driver.c +++ b/drivers/gpu/drm/i915/i915_driver.c @@ -117,15 +117,15 @@ static int i915_get_bridge_dev(struct drm_i915_private *dev_priv) { int domain = pci_domain_nr(to_pci_dev(dev_priv->drm.dev)->bus); - dev_priv->bridge_dev = + dev_priv->gmch.pdev = pci_get_domain_bus_and_slot(domain, 0, PCI_DEVFN(0, 0)); - if (!dev_priv->bridge_dev) { + if (!dev_priv->gmch.pdev) { drm_err(&dev_priv->drm, "bridge device not found\n"); return -EIO; } return drmm_add_action_or_reset(&dev_priv->drm, i915_release_bridge_dev, - dev_priv->bridge_dev); + dev_priv->gmch.pdev); } /* Allocate space for the MCH regs if needed, return nonzero on error */ @@ -138,8 +138,8 @@ intel_alloc_mchbar_resource(struct drm_i915_private *dev_priv) int ret; if (GRAPHICS_VER(dev_priv) >= 4) - pci_read_config_dword(dev_priv->bridge_dev, reg + 4, &temp_hi); - pci_read_config_dword(dev_priv->bridge_dev, reg, &temp_lo); + pci_read_config_dword(dev_priv->gmch.pdev, reg + 4, &temp_hi); + pci_read_config_dword(dev_priv->gmch.pdev, reg, &temp_lo); mchbar_addr = ((u64)temp_hi << 32) | temp_lo; /* If ACPI doesn't have it, assume we need to allocate it ourselves */ @@ -150,26 +150,26 @@ intel_alloc_mchbar_resource(struct drm_i915_private *dev_priv) #endif /* Get some space for it */ - dev_priv->mch_res.name = "i915 MCHBAR"; - dev_priv->mch_res.flags = IORESOURCE_MEM; - ret = pci_bus_alloc_resource(dev_priv->bridge_dev->bus, - &dev_priv->mch_res, + dev_priv->gmch.mch_res.name = "i915 MCHBAR"; + dev_priv->gmch.mch_res.flags = IORESOURCE_MEM; + ret = pci_bus_alloc_resource(dev_priv->gmch.pdev->bus, + &dev_priv->gmch.mch_res, MCHBAR_SIZE, MCHBAR_SIZE, PCIBIOS_MIN_MEM, 0, pcibios_align_resource, - dev_priv->bridge_dev); + dev_priv->gmch.pdev); if (ret) { drm_dbg(&dev_priv->drm, "failed bus alloc: %d\n", ret); - dev_priv->mch_res.start = 0; + dev_priv->gmch.mch_res.start = 0; return ret; } if (GRAPHICS_VER(dev_priv) >= 4) - pci_write_config_dword(dev_priv->bridge_dev, reg + 4, - upper_32_bits(dev_priv->mch_res.start)); + pci_write_config_dword(dev_priv->gmch.pdev, reg + 4, + upper_32_bits(dev_priv->gmch.mch_res.start)); - pci_write_config_dword(dev_priv->bridge_dev, reg, - lower_32_bits(dev_priv->mch_res.start)); + pci_write_config_dword(dev_priv->gmch.pdev, reg, + lower_32_bits(dev_priv->gmch.mch_res.start)); return 0; } @@ -184,13 +184,13 @@ intel_setup_mchbar(struct drm_i915_private *dev_priv) if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) return; - dev_priv->mchbar_need_disable = false; + dev_priv->gmch.mchbar_need_disable = false; if (IS_I915G(dev_priv) || IS_I915GM(dev_priv)) { - pci_read_config_dword(dev_priv->bridge_dev, DEVEN, &temp); + pci_read_config_dword(dev_priv->gmch.pdev, DEVEN, &temp); enabled = !!(temp & DEVEN_MCHBAR_EN); } else { - pci_read_config_dword(dev_priv->bridge_dev, mchbar_reg, &temp); + pci_read_config_dword(dev_priv->gmch.pdev, mchbar_reg, &temp); enabled = temp & 1; } @@ -201,15 +201,15 @@ intel_setup_mchbar(struct drm_i915_private *dev_priv) if (intel_alloc_mchbar_resource(dev_priv)) return; - dev_priv->mchbar_need_disable = true; + dev_priv->gmch.mchbar_need_disable = true; /* Space is allocated or reserved, so enable it. */ if (IS_I915G(dev_priv) || IS_I915GM(dev_priv)) { - pci_write_config_dword(dev_priv->bridge_dev, DEVEN, + pci_write_config_dword(dev_priv->gmch.pdev, DEVEN, temp | DEVEN_MCHBAR_EN); } else { - pci_read_config_dword(dev_priv->bridge_dev, mchbar_reg, &temp); - pci_write_config_dword(dev_priv->bridge_dev, mchbar_reg, temp | 1); + pci_read_config_dword(dev_priv->gmch.pdev, mchbar_reg, &temp); + pci_write_config_dword(dev_priv->gmch.pdev, mchbar_reg, temp | 1); } } @@ -218,28 +218,28 @@ intel_teardown_mchbar(struct drm_i915_private *dev_priv) { int mchbar_reg = GRAPHICS_VER(dev_priv) >= 4 ? MCHBAR_I965 : MCHBAR_I915; - if (dev_priv->mchbar_need_disable) { + if (dev_priv->gmch.mchbar_need_disable) { if (IS_I915G(dev_priv) || IS_I915GM(dev_priv)) { u32 deven_val; - pci_read_config_dword(dev_priv->bridge_dev, DEVEN, + pci_read_config_dword(dev_priv->gmch.pdev, DEVEN, &deven_val); deven_val &= ~DEVEN_MCHBAR_EN; - pci_write_config_dword(dev_priv->bridge_dev, DEVEN, + pci_write_config_dword(dev_priv->gmch.pdev, DEVEN, deven_val); } else { u32 mchbar_val; - pci_read_config_dword(dev_priv->bridge_dev, mchbar_reg, + pci_read_config_dword(dev_priv->gmch.pdev, mchbar_reg, &mchbar_val); mchbar_val &= ~1; - pci_write_config_dword(dev_priv->bridge_dev, mchbar_reg, + pci_write_config_dword(dev_priv->gmch.pdev, mchbar_reg, mchbar_val); } } - if (dev_priv->mch_res.start) - release_resource(&dev_priv->mch_res); + if (dev_priv->gmch.mch_res.start) + release_resource(&dev_priv->gmch.mch_res); } static int i915_workqueues_init(struct drm_i915_private *dev_priv) |