summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/i915/intel_dp.c
diff options
context:
space:
mode:
authorVille Syrjälä <ville.syrjala@linux.intel.com>2014-10-16 21:30:07 +0300
committerDaniel Vetter <daniel.vetter@ffwll.ch>2014-11-04 23:22:05 +0100
commite7a89acea863ffdffa66f4c6cda272eebd893c51 (patch)
tree302daf8fd8391568365172fffc892df17bad3b1f /drivers/gpu/drm/i915/intel_dp.c
parent3936fcf453af4de87303f42bb34ef5e3eb13c139 (diff)
drm/i915: Warn if panel power is already on when enabling it
We should never enable the panel power twice. That would indicate a bug somewhere else as we would need to enable the port twice without disabling it in between. Also print the port name. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Imre Deak <imre.deak@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Diffstat (limited to 'drivers/gpu/drm/i915/intel_dp.c')
-rw-r--r--drivers/gpu/drm/i915/intel_dp.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 21fb42241b2f..9db977b475f8 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1629,10 +1629,10 @@ static void edp_panel_on(struct intel_dp *intel_dp)
DRM_DEBUG_KMS("Turn eDP port %c panel power on\n",
port_name(dp_to_dig_port(intel_dp)->port));
- if (edp_have_panel_power(intel_dp)) {
- DRM_DEBUG_KMS("eDP power already on\n");
+ if (WARN(edp_have_panel_power(intel_dp),
+ "eDP port %c panel power already on\n",
+ port_name(dp_to_dig_port(intel_dp)->port)))
return;
- }
wait_panel_power_cycle(intel_dp);