summaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/i915/vlv_sideband.c
diff options
context:
space:
mode:
authorJani Nikula <jani.nikula@intel.com>2023-11-14 12:45:33 +0200
committerJani Nikula <jani.nikula@intel.com>2023-11-17 14:59:55 +0200
commit9fda18c2c32a42e6c9fb68893b9628d6a5319555 (patch)
treef4eb399880435a30bd85846f5a179a28626f82ec /drivers/gpu/drm/i915/vlv_sideband.c
parent9d6953335284fc37f25bf8488a15ee9444198248 (diff)
drm/i915: add vlv_pipe_to_phy() helper to replace DPIO_PHY()
Add a helper with better typing and handing for bogus input, and better in line with vlv_dig_port_to_channel(), vlv_dig_port_to_phy(), and vlv_pipe_to_channel(). Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231114104534.4180144-2-jani.nikula@intel.com
Diffstat (limited to 'drivers/gpu/drm/i915/vlv_sideband.c')
-rw-r--r--drivers/gpu/drm/i915/vlv_sideband.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/gpu/drm/i915/vlv_sideband.c b/drivers/gpu/drm/i915/vlv_sideband.c
index b98dec3ad817..f7df55217845 100644
--- a/drivers/gpu/drm/i915/vlv_sideband.c
+++ b/drivers/gpu/drm/i915/vlv_sideband.c
@@ -229,7 +229,8 @@ static u32 vlv_dpio_phy_iosf_port(struct drm_i915_private *i915, enum dpio_phy p
u32 vlv_dpio_read(struct drm_i915_private *i915, enum pipe pipe, int reg)
{
- u32 port = vlv_dpio_phy_iosf_port(i915, DPIO_PHY(pipe));
+ enum dpio_phy phy = vlv_pipe_to_phy(pipe);
+ u32 port = vlv_dpio_phy_iosf_port(i915, phy);
u32 val = 0;
vlv_sideband_rw(i915, DPIO_DEVFN, port, SB_MRD_NP, reg, &val);
@@ -248,7 +249,8 @@ u32 vlv_dpio_read(struct drm_i915_private *i915, enum pipe pipe, int reg)
void vlv_dpio_write(struct drm_i915_private *i915,
enum pipe pipe, int reg, u32 val)
{
- u32 port = vlv_dpio_phy_iosf_port(i915, DPIO_PHY(pipe));
+ enum dpio_phy phy = vlv_pipe_to_phy(pipe);
+ u32 port = vlv_dpio_phy_iosf_port(i915, phy);
vlv_sideband_rw(i915, DPIO_DEVFN, port, SB_MWR_NP, reg, &val);
}