diff options
author | Zack Rusin <zackr@vmware.com> | 2023-03-14 17:14:45 -0400 |
---|---|---|
committer | Zack Rusin <zackr@vmware.com> | 2023-03-15 16:15:25 -0400 |
commit | 328839ff93709a517e89ba1de1132c5d138e5dcb (patch) | |
tree | 556c49f9db4b419e2863ecbd28850551103aeacb /drivers/gpu/drm/nouveau | |
parent | 4230cea89cafb11b2c2e4dcac8b505e7a766b386 (diff) |
drm/vmwgfx: Fix src/dst_pitch confusion
The src/dst_pitch got mixed up during the rework of the function, make
sure the offset's refer to the correct one.
Spotted by clang:
Clang warns (or errors with CONFIG_WERROR):
drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:509:29: error: variable 'dst_pitch' is uninitialized when used here [-Werror,-Wuninitialized]
src_offset = ddirty->top * dst_pitch + ddirty->left * stdu->cpp;
^~~~~~~~~
drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:492:26: note: initialize the variable 'dst_pitch' to silence this warning
s32 src_pitch, dst_pitch;
^
= 0
1 error generated.
Signed-off-by: Zack Rusin <zackr@vmware.com>
Reported-by: Nathan Chancellor <nathan@kernel.org>
Reported-by: Dave Airlie <airlied@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1811
Fixes: 39985eea5a6d ("drm/vmwgfx: Abstract placement selection")
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Martin Krastev <krastevm@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230314211445.1363828-1-zack@kde.org
Diffstat (limited to 'drivers/gpu/drm/nouveau')
0 files changed, 0 insertions, 0 deletions